small code and docs refactoring #3681
Conversation
StrikerRUS
requested review from
btrotta,
chivee,
guolinke,
henry0312,
huanzhang12,
jameslamb,
Laurae2 and
wxchan
as code owners
| # Ignore unknown #pragma warning | ||
| if((CMAKE_CXX_COMPILER_ID STREQUAL "Clang") | ||
| OR (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")) | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas") |
There was a problem hiding this comment.
Should be set after -Wall to take effect.
| @@ -272,6 +266,9 @@ if(UNIX OR MINGW OR CYGWIN) | |||
| if(USE_SWIG) | |||
| SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-strict-aliasing") | |||
| endif() | |||
| if(NOT USE_OPENMP) | |||
| SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas -Wno-unused-private-field") | |||
There was a problem hiding this comment.
Hide
/Users/runner/work/1/s/src/objective/binary_objective.hpp:208:14: warning: private field 'deterministic_' is not used [-Wunused-private-field]
const bool deterministic_;
^
with AppleClang.
| @@ -408,6 +400,14 @@ LIGHTGBM_C_EXPORT int LGBM_DatasetAddFeaturesFrom(DatasetHandle target, | |||
|
|
|||
| // --- start Booster interfaces | |||
|
|
|||
| /*! | |||
| * \brief Get boolean representing whether booster is fitting linear trees. | |||
| * \param handle Handle of booster | |||
There was a problem hiding this comment.
Should be booster, not dataset.
| if (linear_tree) { | ||
| if (device_type == std::string("gpu")) { | ||
| if (device_type != std::string("cpu")) { |
There was a problem hiding this comment.
To generalize for possible future new enum options.
| @@ -600,7 +600,6 @@ Dataset* DatasetLoader::LoadFromBinFile(const char* data_filename, const char* b | |||
| } | |||
| mem_ptr = buffer.data(); | |||
| const float* tmp_ptr_raw_row = reinterpret_cast<const float*>(mem_ptr); | |||
| std::vector<float> curr_row(dataset->num_numeric_features_, 0); | |||
| @@ -211,7 +211,7 @@ void LinearTreeLearner::CalculateLinear(Tree* tree, bool is_refit, const score_t | |||
| } else { | |||
| raw_features = tree->branch_features(i); | |||
| } | |||
| std::sort(raw_features.begin(), raw_features.end()); | |||
| std::stable_sort(raw_features.begin(), raw_features.end()); | |||
There was a problem hiding this comment.
Not sure about this. Refer to #2154 (comment) and #1739.
@btrotta Is there a possibility to meet equivalent elements in raw_features?
cc @guolinke
There was a problem hiding this comment.
I think it is not need for stable-sort. I think here is only to get unique feature indices.
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
No description provided.