Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python][tests] small Python tests cleanup #3715

Merged
merged 1 commit into from
Jan 4, 2021
Merged

[python][tests] small Python tests cleanup #3715

merged 1 commit into from
Jan 4, 2021

Conversation

StrikerRUS
Copy link
Collaborator

  • Rename temp model file to not overcomplicate .gitignore.
  • Reduce code duplication in params definition.
  • Use asserts from unittest module for consistency with the rest codebase.

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally have a preference for assert with an arbitrary expression instead of the added indirection of the unittest builtins, but I wont block this PR

@StrikerRUS
Copy link
Collaborator Author

@jameslamb
This looks like a "good first issue" to rewrite all tests removing unittest dependency and referring test_dask.py and test_dual.py as examples. WDYT?

@jameslamb
Copy link
Collaborator

I agree! I can write it up

@StrikerRUS
Copy link
Collaborator Author

Thanks! Please do it. 🙂

@StrikerRUS StrikerRUS merged commit 69798c3 into master Jan 4, 2021
@StrikerRUS StrikerRUS deleted the py_tests branch January 4, 2021 18:11
@jameslamb
Copy link
Collaborator

Thanks! Please do it.

added #3732. Feel free to edit it if there's anything you'd like to change.

@StrikerRUS
Copy link
Collaborator Author

Thank you!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants