Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] move Python Mac jobs from Travis to GitHub Actions #3745

Merged
merged 12 commits into from Jan 10, 2021
Merged

Conversation

jameslamb
Copy link
Collaborator

This is another step towards removing Travis from this project, in response to recent policy changes there (#3519).

This was originally proposed in #3672. On that PR, there is still a bit of work to be done for Linux jobs (#3672 (comment)), so this pulls out just the Mac changes so that we can reduce our reliance on Travis and start using GitHub Actions. The sooner this is done, the sooner we'll start learning about things that can be changed / fixed on GitHub Actions.

@jameslamb jameslamb removed the request for review from Laurae2 January 10, 2021 15:35
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extracting these changes in a separate PR! Please check some my initial comments below. Also, please temporary change compiler to clang and trigger CI to make sure we didn't forget any settings.

.github/workflows/python_package.yml Show resolved Hide resolved
.github/workflows/python_package.yml Outdated Show resolved Hide resolved
.github/workflows/python_package.yml Outdated Show resolved Hide resolved
.github/workflows/python_package.yml Outdated Show resolved Hide resolved
.github/workflows/python_package.yml Outdated Show resolved Hide resolved
.github/workflows/python_package.yml Outdated Show resolved Hide resolved
.github/workflows/python_package.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two clean-up comments.

.github/workflows/python_package.yml Outdated Show resolved Hide resolved
.github/workflows/python_package.yml Outdated Show resolved Hide resolved
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
@jameslamb jameslamb merged commit c7c4e08 into master Jan 10, 2021
@jameslamb jameslamb deleted the ci/mac-jobs branch January 10, 2021 23:38
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants