Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask] fix Dask import order #3788

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Conversation

jameslamb
Copy link
Collaborator

This PR has two small cleanup actions for the Dask module.

  1. moves scipy import above relative imports like from .basic, matching the ordering we use in other modules
  2. replaces unused variables in tests with _

I found both of these small things with pylint.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jameslamb jameslamb merged commit 4007b34 into microsoft:master Jan 19, 2021
@jameslamb jameslamb deleted the misc/dask-order branch January 19, 2021 18:06
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants