Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dask] remove unused private _client attribute #3904

Merged
merged 4 commits into from
Feb 3, 2021
Merged

Conversation

StrikerRUS
Copy link
Collaborator

Refer to #3883 (comment).

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is _client not required? The other properties on scikit-learn estimators seem to all have an attribute like that with a single leading underscore:

self._class_weight = None
self._class_map = None
self._n_features = None
self._n_features_in = None
self._classes = None
self._n_classes = None

@StrikerRUS
Copy link
Collaborator Author

The other properties on scikit-learn estimators seem to all have an attribute like that with a single leading underscore:

Yeah, but this is not required by sklearn. It is made for storing underlying value of a property (with training _). You chose to use function for this purpose.

@jameslamb jameslamb self-requested a review February 3, 2021 15:49
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I thought that #3883 (comment) referred to literally that one line you commented on, not the property completely.

@jameslamb jameslamb merged commit b1e000c into master Feb 3, 2021
@jameslamb jameslamb deleted the dask_cleanup branch February 3, 2021 16:44
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants