Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] fix typo in linear learner test #4109

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

jameslamb
Copy link
Collaborator

This fixes a typo in params on one of the R unit tests, which led to the warning noted in #4105 (comment)

[LightGBM] [Warning] Unknown parameter: categorical_featurs

That test specifically checks that training a model in R using linear models at the leaves works if you also have categorical features. So this typo might have actually prevented that test from running correctly and covering what it was expected to.

I also looked through the logs from a recent build of the r-package (windows-2019, MSVC, R 4, cmake) CI job. Those jobs use Rscript testthat.R instead of R CMD CHECK, so you can see all of the logs from the tests. For the other warnings that look problematic, I've opened #4108 with the tag good first issue so that it might be addressed by other contributors.

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge after re-runnning Azure due to Clang installation error and our current "best friend" 104 socket error.

@jameslamb jameslamb merged commit 65349b4 into microsoft:master Mar 25, 2021
@jameslamb jameslamb deleted the fix/r-warnings branch March 25, 2021 19:40
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants