Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] added f-strings to docs/conf.py #4147

Merged
merged 11 commits into from
Apr 5, 2021
Merged

[python] added f-strings to docs/conf.py #4147

merged 11 commits into from
Apr 5, 2021

Conversation

NovusEdge
Copy link
Contributor

No description provided.

@NovusEdge
Copy link
Contributor Author

#4136

@NovusEdge
Copy link
Contributor Author

@StrikerRUS
please do let me know about any changes to be made in the split PRs

@jameslamb
Copy link
Collaborator

@StrikerRUS
please do let me know about any changes to be made in the split PRs

Please see my suggestions at #4142 (review). These apply to all of the PRs you've opened, and I think will help you debug locally.

@StrikerRUS StrikerRUS changed the title added f-strings to docs/conf.py [python] added f-strings to docs/conf.py Apr 2, 2021
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NovusEdge Thanks! Please take a look at my comments below:

docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
NovusEdge and others added 3 commits April 2, 2021 20:44
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I don't believe that macOS R-package jobs are failing due to the changes from this PR. I guess we can wait a little bit with a hope that issues will go away without our help.

@jameslamb
Copy link
Collaborator

jameslamb commented Apr 2, 2021

Hopefully should be resolved soon! Looks like our old friend, the MiKTeX mactex mirror 😆

==> Downloading http://mirror.ctan.org/systems/mac/mactex/mactex-basictex-20200407.pkg
==> Downloading from https://ctan.math.illinois.edu/systems/mac/mactex/mactex-basictex-20200407.pkg
curl: (22) The requested URL returned error: 404 
Error: Download failed on Cask 'basictex' with message: Download failed: http://mirror.ctan.org/systems/mac/mactex/mactex-basictex-20200407.pkg
sudo: tlmgr: command not found
sudo: tlmgr: command not found

https://github.com/microsoft/LightGBM/pull/4147/checks?check_run_id=2254678263

@jameslamb
Copy link
Collaborator

I've updated this PR to latest master to get the CI fixes from #4161. Will merge if / when it builds successfully.

Thanks for the help with these @NovusEdge !

@jameslamb jameslamb merged commit b2d73de into microsoft:master Apr 5, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants