Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix broken MS MPI link in Installation Guide #4224

Merged
merged 1 commit into from
Apr 25, 2021
Merged

Conversation

jameslamb
Copy link
Collaborator

The "Link Checks" job is currently failing with the following error.

URL        `https://www.microsoft.com/en-us/download/details.aspx?id=100593'
Name       `MS MPI'
Parent URL file:///home/runner/work/LightGBM/LightGBM/docs/_build/html/Installation-Guide.html, line 596, col 28
Real URL   https://www.microsoft.com/en-us/download/404Error.aspx
Check time 1.069 seconds
Size       92.45KB
Info       Redirected to
           `https://www.microsoft.com/en-us/download/404Error.aspx'.
Result     Error: 404 Not Found

Most recent build was 10 hours ago: https://github.com/microsoft/LightGBM/actions/runs/782291613

I see that broken download links have also been reported in the MS MPI repo: microsoft/Microsoft-MPI#54

This PR proposes linking to the official release notes for MS MPI instead of to aa specific download in the Microsoft Download center. That should fix the failing build and I think it's a better link anyway because users can read release notes AND get downloads there.

@jameslamb
Copy link
Collaborator Author

jameslamb commented Apr 25, 2021

ugh sorry, I don't understand how these extra commits made it onto this branch.

image

Will fix it. fixed

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StrikerRUS StrikerRUS merged commit eb7a1b7 into master Apr 25, 2021
@StrikerRUS StrikerRUS deleted the fix/mpi-doc branch April 25, 2021 20:29
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants