-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][ci] bump versions of R-package dependencies at RTD #4488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, looks good to me! I checked the new docs from this and don't see any issues.
But for my own education...how did you figure out that upgrading the R dependencies was necessary to fix the problem? I don't see anything in the logs from the most recent failed build (https://readthedocs.org/api/v2/build/14324467.txt) that would have led me to that conclusion.
@jameslamb Yeah, there were no logs because we accumulate stdout and stderr first and then dump the combined result Lines 286 to 301 in fdc582e
But due to the time out error we didn't reach "dump" step. First, I disabled R docs completely to narrow the root cause. |
ah ok great, thanks for the explanation! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Fixed #4487.