Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][ci] bump versions of R-package dependencies at RTD #4488

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Conversation

StrikerRUS
Copy link
Collaborator

Fixed #4487.

image

image

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, looks good to me! I checked the new docs from this and don't see any issues.

But for my own education...how did you figure out that upgrading the R dependencies was necessary to fix the problem? I don't see anything in the logs from the most recent failed build (https://readthedocs.org/api/v2/build/14324467.txt) that would have led me to that conclusion.

@StrikerRUS
Copy link
Collaborator Author

@jameslamb Yeah, there were no logs because we accumulate stdout and stderr first and then dump the combined result

LightGBM/docs/conf.py

Lines 286 to 301 in fdc582e

try:
# Warning! The following code can cause buffer overflows on RTD.
# Consider suppressing output completely if RTD project silently fails.
# Refer to https://github.com/svenevs/exhale
# /blob/fe7644829057af622e467bb529db6c03a830da99/exhale/deploy.py#L99-L111
process = Popen(['/bin/bash'],
stdin=PIPE, stdout=PIPE, stderr=PIPE,
universal_newlines=True)
stdout, stderr = process.communicate(commands)
output = '\n'.join([i for i in (stdout, stderr) if i is not None])
if process.returncode != 0:
raise RuntimeError(output)
else:
print(output)
except BaseException as e:
raise Exception(f"An error has occurred while generating documentation for R-package\n{e}")

But due to the time out error we didn't reach "dump" step.

First, I disabled R docs completely to narrow the root cause.
d332460
That build without R docs was successful and took only 100 seconds. After that I was sure that something is wrong with R-package installation or R docs generation process. Then I just started with the simplest idea of upgrading deps because I remember one case when some particular package build had been removed from anaconda.org repo instead of pushing new build number/hash.

@StrikerRUS StrikerRUS merged commit 2370961 into master Jul 26, 2021
@StrikerRUS StrikerRUS deleted the test_docs branch July 26, 2021 16:41
@jameslamb
Copy link
Collaborator

Then I just started with the simplest idea of upgrading deps because I remember one case when some particular package build had been removed from anaconda.org repo instead of pushing new build number/hash.

ah ok great, thanks for the explanation!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RTD builds are failing due to time out
2 participants