Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] remove pin on tinytex in R CI jobs #5821

Merged
merged 3 commits into from
Apr 7, 2023
Merged

[ci] remove pin on tinytex in R CI jobs #5821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2962e39
[ci] unpin tinytex
jameslamb Apr 6, 2023
aafaf0d
try installing from CRAN
jameslamb Apr 7, 2023
17ceeba
install lattice from MRAN
jameslamb Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .ci/test_r_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ if [[ $OS_NAME == "macos" ]]; then
fi
fi

# fix for issue where CRAN was not returning {lattice} when using R 3.6
# "Warning: dependency ‘lattice’ is not available"
if [[ "${R_MAJOR_VERSION}" == "3" ]]; then
Rscript --vanilla -e "install.packages('lattice', repos = 'https://mran.microsoft.com', lib = '${R_LIB_PATH}')"
fi
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't totally understand, but it seems like CRAN (both from RStudio and the official CRAN) have stopped serving {lattice} to R 3.6 🤷🏻

official CRAN

docker run \
    --rm \
    rocker/verse:3.6 \
    Rscript -e "install.packages('lattice', repos = 'https://cran.r-project.org')"
Installing package into ‘/usr/local/lib/R/site-library’
(as ‘lib’ is unspecified)
Warning message:
package ‘lattice’ is not available (for R version 3.6.0)

RStudio

docker run \
    --rm \
    rocker/verse:3.6 \
    Rscript -e "install.packages('lattice', repos = 'https://cran.rstudio.com')"
Installing package into ‘/usr/local/lib/R/site-library’
(as ‘lib’ is unspecified)
Warning message:
package ‘lattice’ is not available (for R version 3.6.0)

MRAN

docker run \
    --rm \
    rocker/verse:3.6 \
    Rscript -e "install.packages('lattice', repos = 'https://mran.microsoft.com')"
Installing package into ‘/usr/local/lib/R/site-library’
(as ‘lib’ is unspecified)
trying URL 'https://mran.microsoft.com/src/contrib/lattice_0.20-45.tar.gz'
Content type 'application/octet-stream' length 399470 bytes (390 KB)
==================================================
downloaded 390 KB

* installing *source* package ‘lattice’ ...
...
* DONE (lattice)


# Manually install Depends and Imports libraries + 'knitr', 'RhpcBLASctl', 'rmarkdown', 'testthat'
# to avoid a CI-time dependency on devtools (for devtools::install_deps())
# NOTE: testthat is not required when running rchk
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/r_package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,6 @@ jobs:
env:
CTAN_MIRROR: https://ctan.math.illinois.edu/systems/win32/miktex
TINYTEX_INSTALLER: TinyTeX
# pinning to an old version to address breaking changes to paths not being available yet
# (ref: https://github.com/r-lib/actions/issues/713#issuecomment-1481293175)
TINYTEX_VERSION: '2023.03'
- name: Setup and run tests on Linux and macOS
if: matrix.os == 'macOS-latest' || matrix.os == 'ubuntu-latest'
shell: bash
Expand Down