New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package the UnixPortSupplier interop assembly #545
Package the UnixPortSupplier interop assembly #545
Conversation
Ensure that the MS.VS.Debugger.Interop.UnixPortSupplier.DesignTime assembly is packaged into the MDD NuGet package so it can be referenced from other projects.
MIEngine.mdd.nuspec
Outdated
@@ -14,6 +14,7 @@ | |||
<files> | |||
<file src="drop\Release\ReferenceAssemblies\*.xml" target="ref\dotnet" /> | |||
<file src="drop\Release\ReferenceAssemblies\Microsoft.DebugEngineHost.dll" target="ref\dotnet" /> | |||
<file src="drop\Release\ReferenceAssemblies\Microsoft.VisualStudio.Debugger.Interop.UnixPortSupplier.DesignTime.dll" target="ref\dotnet" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be difficult to make a separate nuget package instead? This guy makes sense to be in its own package so that other things can easily reference it.
MIEngine.mdd.nuspec
Outdated
@@ -14,6 +14,7 @@ | |||
<files> | |||
<file src="drop\Release\ReferenceAssemblies\*.xml" target="ref\dotnet" /> | |||
<file src="drop\Release\ReferenceAssemblies\Microsoft.DebugEngineHost.dll" target="ref\dotnet" /> | |||
<file src="drop\Release\ReferenceAssemblies\Microsoft.VisualStudio.Debugger.Interop.UnixPortSupplier.DesignTime.dll" target="ref\dotnet" /> | |||
<file src="drop\Release\Microsoft.MICore.dll" target="ref\dotnet" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably include Microsoft.VisualStudio.Debugger.Interop.UnixPortSupplier.DesignTime.xml also.
Move UnixPortSupplier reference assembly to its own NuGet package. The XML file (but not the DLL) was being included in the main MDD package already, so I've removed it.
Ensure that the MS.VS.Debugger.Interop.UnixPortSupplier.DesignTime assembly is packaged into a NuGet package so it can be referenced from other projects.
* Fixed 'pwd' invocation (#533) * Unzip prompts when overwriting existing files. Fixing it by force overwriting on top of existing files. * remove '-f' flag from unzip unzip -f doesn't do what you think it does. * Stop calling CheckModules for lldb/clrdbg (#542) MIEngine had a method that we use for GDB to find the list of loaded modules. This method wasn't intended to be called for lldb/clrdbg, but there was one race where it could happen - if a stopping event was received before the SDD continued program create we will call CheckModule. This adds a guard to fix this. This should resolve dotnet/vscode-csharp#1035. * Support breakpoints in sourcefiles with same base name. (#541) * Support breakpoints in sourcefiles with same base name. - projects can send in source file mapping data - users can supply solution-specific additional source map file * Switch from using Array.Foreach to foreach * Review response, support attach path * Check for empty editor string * Fix build on Dev15 (#544) Adjusts targets files to check both old and new locations for csc.exe * Package the UnixPortSupplier interop assembly (#545) Ensure that the MS.VS.Debugger.Interop.UnixPortSupplier.DesignTime assembly is packaged into a NuGet package so it can be referenced from other projects. * When specifying only a filename for miDebuggerPath, search $Path for debugger * Code Review Feedback * Do not include metadata.json in NuGet packages (#548) Fixes build break, since Microbuild no longer produces this file * Fix Natvis for DisplayString conditionals in C Issue: gdb returns "1" and "0" instead of "true" and "false" when debugging C and a condition is passed for evaluation. Changed code to check for either "true" or "1" * Code Review Feedback * Add non-shell commands to SSH port supplier (#554) Extends the SSH port supplier to allow commands to be run without starting a shell and allocating a PTY on the remote host. * Fix for Stop at entry with gdb<->gdbserver * Fix typo * Fixes for thread-created and terminate/detach 1. Fix for Pause on OS X with lldb. LLDB does not break on attach so threads were not being sent to the UI. Fix was to send back messages when threads are created directly 2. fix for detach/terminate. With the change to do an internal break, it was sending -exec-interrupt, -exec-abort and then -exec-continue which was causing errors. added check in DoInternalBreakActions to only continue if we are not terminating or detaching. 3. Fix for ErrorEvent. on LLDB, the message format is ^error,message="" but in gdb it is ^error,msg="". Added a special case for it. * Update InstallToVSCode.cmd to reflect vsdbg changes * Fix for coredump debugging and a timing issue (#560) * Core dump threads start with LWP. Added a target-id parsing for it * when new threads are created, mark it as state change before thread-info * which can take a while. * Fix for threading issue (#561) * Fix for threading issue * Issue was timing in that the new thread was being populated in MIEngine * without the id being added to the threadgroup. Moved the relevant block. * Also blocked it from requesting thread-info from clrdbg since this * doesn't work while running in clrdbg * Pull Request Feedback
Ensure that the MS.VS.Debugger.Interop.UnixPortSupplier.DesignTime
assembly is packaged into the MDD NuGet package so it can be referenced
from other projects.