-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the place for AllowQueryAllRuntimeVersions #281
Merged
YuliiaKovalova
merged 3 commits into
main
from
dev/ykovalova/change_api_for_AllowQueryAllRuntimeVersions
Mar 4, 2024
Merged
Update the place for AllowQueryAllRuntimeVersions #281
YuliiaKovalova
merged 3 commits into
main
from
dev/ykovalova/change_api_for_AllowQueryAllRuntimeVersions
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isualStudio.Setup.Configuration.Interop version
jasonmalinowski
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works for us; I don't know what your breaking change policy is but we haven't consumed the other one yet so that's fine for us.
rainersigwald
requested changes
Feb 22, 2024
rainersigwald
approved these changes
Mar 4, 2024
Hi @jasonmalinowski, The package with the requested change has been just published: https://github.com/microsoft/MSBuildLocator/releases/tag/v1.7.8 |
renovate bot
added a commit
to buehler/dotnet-operator-sdk
that referenced
this pull request
Mar 14, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Microsoft.Build.Locator](https://togithub.com/microsoft/MSBuildLocator) | `1.7.1` -> `1.7.8` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Microsoft.Build.Locator/1.7.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Microsoft.Build.Locator/1.7.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Microsoft.Build.Locator/1.7.1/1.7.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Microsoft.Build.Locator/1.7.1/1.7.8?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>microsoft/MSBuildLocator (Microsoft.Build.Locator)</summary> ### [`v1.7.8`](https://togithub.com/microsoft/MSBuildLocator/releases/tag/v1.7.8) ##### What's Changed - Onboarding MicroBuild by [@​MichalPavlik](https://togithub.com/MichalPavlik) in [microsoft/MSBuildLocator#280 - Add ApplyDotNetSdkEnvironmentVariables for custom MSBuild path(s) by [@​YuliiaKovalova](https://togithub.com/YuliiaKovalova) in [microsoft/MSBuildLocator#283 - Update the place for AllowQueryAllRuntimeVersions by [@​YuliiaKovalova](https://togithub.com/YuliiaKovalova) in [microsoft/MSBuildLocator#281 - Port the changes from main - ApplyDotNetSdkEnvironmentVariables, AllowQueryAllRuntimeVersions by [@​YuliiaKovalova](https://togithub.com/YuliiaKovalova) in [microsoft/MSBuildLocator#284 **Full Changelog**: microsoft/MSBuildLocator@v1.7.1...v1.7.8 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/buehler/dotnet-operator-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
No functional changes, just update the place of the flag AllowQueryAllRuntimeVersions in order to address the Roslyn's team needs. See #265 (comment) for more details.