Avoid restoring net45 targeting pack in Traversal SDK #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NoTargets SDK already sets the AutomaticallyUseReferenceAssemblyPackages property to false but the Traversal SDK didn't. As the Traversal SDK defines a default TFM (net45), the reference assembly pack is being downloaded automatically. This shows us as a prebuild in dotnet/runtime and other repositories that build from source.
|
@jeffkl @AndyGerlicher any idea why CI is failing? Unsure if that's related to my change as it complains about a file not found. I wouldn't expect the current Traversal tests to depend on the .NET Framework reference assemblies. EDIT: Looks like CI just passed after a retry (?). |
|
Yeah sorry that's a weird error that MSBuild throws occasionally, I haven't had time to root cause it. |
jeffkl
reviewed
Mar 23, 2023
… is imported so the default value is respected.
jeffkl
approved these changes
Mar 23, 2023
|
Omg, sorry for that, I should have tested it locally... Thanks for the fix. After merging the change in, can we please publish a new version to nuget.org? |
Yes absolutely, I usually publish a package for every change |
ViktorHofer
added a commit
to dotnet/runtime
that referenced
this pull request
Mar 24, 2023
Avoids net45 prebuilds in Traversal projects: microsoft/MSBuildSdks#430
akoeplinger
pushed a commit
to dotnet/runtime
that referenced
this pull request
Mar 24, 2023
Avoids net45 prebuilds in Traversal projects: microsoft/MSBuildSdks#430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NoTargets SDK already sets the AutomaticallyUseReferenceAssemblyPackages property to false but the Traversal SDK didn't. As the Traversal SDK defines a default TFM (net45), the reference assembly pack is being downloaded automatically. This shows us as a prebuild in dotnet/runtime and other repositories that build from source.
cc @NikolaMilosavljevic