Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Fix for Set Position and Rotation #138

Merged
merged 15 commits into from
Jan 25, 2021
Merged

Code Fix for Set Position and Rotation #138

merged 15 commits into from
Jan 25, 2021

Conversation

shreyalpandit
Copy link
Contributor

@shreyalpandit shreyalpandit commented Jan 22, 2021 •
edited
Loading

Fixes #74

Short description of what this resolves:

-Accessing the transform should be done as few times as possible

Changes proposed in this pull request:

-Checks for two subsequent lines assigning position and rotation
-Suggest SetPositionAndRotation to reduce access

@shreyalpandit shreyalpandit requested a review from a team as a code owner January 22, 2021 23:26
@sailro sailro merged commit b0715f1 into microsoft:main Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sailro sailro sailro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set Position and Rotation
2 participants
@shreyalpandit @sailro