Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Unity to 2018.4.19f1 and salt cache key with unity version #53

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

sailro
Copy link
Member

@sailro sailro commented Mar 26, 2020

Checklist

Short description of what this resolves:

Bump Unity to the latest LTS

Changes proposed in this pull request:

Bump URLs and salt the cache key with the unity version (to prevent unexpected cache issues)

@sailro sailro requested a review from a team as a code owner March 26, 2020 17:07
@sailro
Copy link
Member Author

sailro commented Mar 26, 2020

Force-pushed to compare non cached/cached times:

Execution Time Without cache With cache
CI-macOS 7m1s 1m7s
CI-Windows 6m6s 1m43s

@sailro sailro merged commit 9efd719 into master Mar 26, 2020
@sailro sailro deleted the bump-unity-2018.4.19f1 branch March 26, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants