SPOTenantCdnPolicy: Export properties as empty arrays if in the tenant they are empty strings #4688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
It seems I missed this while fixing #4658.
If IncludeFileExtensions or ExcludeRestrictedSiteClassifications are null in the tenant they are currently being exported as null to the blueprint, but these properties in DSC side are declared as string arrays so when we call Compare-Object against these properties in the blueprint (and they are assigned with an empty array) and the tenant properties (which might be null strings) then it will return that the objects differ and therefore will try to make a change with a null value.
As explained in my original issue the cmdlet Set-PnPTenantCdnPolicy doesn't work with a null PolicyValue so calling it that way will result in an error, this PR doesn't fix the issue with the cmdlet but at least the comparison will work correctly avoiding the call to the cmdlet in this specific case and therefore also avoiding the error.
This Pull Request (PR) fixes the following issues