This repository has been archived by the owner on Mar 22, 2022. It is now read-only.
Log when exception occur in device sources #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Catch exceptions when failing to create a device track source in WebcamSource and MicrophoneSource components, and disable the component before re-throwing the exception to get Unity to log it. This ensures that the components are disabled for consistency. This is a clean-up loosely related to microsoft#335, though the code triggering that issue has been changed so the issue does not occur anymore.
fibann
approved these changes
Jul 3, 2020
djee-ms
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch exceptions when failing to create a device track source in WebcamSource
and MicrophoneSource components, and log the exception with its callstack along
with an error message with the component name.
This is a clean-up loosely related to #335, though the code triggering that
issue has been changed so the issue does not occur anymore.