-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing regression in MRTK3's Profile Editor (#11694)
The #11681 pull request removed the spatialization mixer property from the MRTK3 Profile, but neglected to remove the reference from the associated editor component. This change removes the spatialization mixer from the editor component. Also adding a unit test to help ensure this doesn't break again.
- Loading branch information
Showing
3 changed files
with
51 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
com.microsoft.mrtk.core/Tests/Editor/MRTK3ProfileEditorTest.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT License. | ||
|
||
using NUnit.Framework; | ||
using System.Collections; | ||
using UnityEditor; | ||
using UnityEngine; | ||
using UnityEngine.TestTools; | ||
using UnityEngine.UIElements; | ||
|
||
namespace Microsoft.MixedReality.Toolkit.Core.Tests.EditMode | ||
{ | ||
internal class MRTK3ProfileEditorTest | ||
{ | ||
/// <summary> | ||
/// Verify that the <see cref="MRTK3ProfileEditor"/> window can be opened. | ||
/// </summary> | ||
/// <remarks> | ||
/// This test is disabled when executing in batch mode, since it requires a Unity graphic device. | ||
/// </remarks> | ||
[UnityTest] | ||
public IEnumerator InspectorWindowSmokeTest() | ||
{ | ||
if (Application.isBatchMode) | ||
{ | ||
yield return null; | ||
} | ||
else | ||
{ | ||
var window = SettingsService.OpenProjectSettings("Project/MRTK3"); | ||
Assert.IsNotNull(window, "The MRTK Profile editor window should have been opened"); | ||
|
||
var panel = window.rootVisualElement.Query<IMGUIContainer>(className: "settings-panel-imgui-container").First(); | ||
Assert.IsNotNull(panel, "There should have hand a settings panel created for the MRTK Profile."); | ||
|
||
yield return null; | ||
} | ||
} | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
com.microsoft.mrtk.core/Tests/Editor/MRTK3ProfileEditorTest.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.