Removing MRTK3's SpatializationMixer property until usage is properly defined. #11681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMollis
changed the title
|
Re-thinking this...might just remove the unused property. |
…later, once a usage is properly defined.
AMollis
changed the title
marlenaklein-msft
approved these changes
Jul 6, 2023
AMollis
changed the title
AMollis
added a commit
that referenced
this pull request
Jul 10, 2023
The #11681 pull request removed the spatialization mixer property from the MRTK3 Profile, but neglected to remove the reference from the associated editor component. This change removes the spatialization mixer from the editor component. Also adding a unit test to help ensure this doesn't break again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removing MRT3's SpatializationMixer property until usage is properly defined.
This property is not being using outside of an example script. Even the example script is not being used in any sample scene.
Having an "experimental" or "example" property in MRTK's main configuration is not desired. Once an official (non-experimental) solution of handling spatialization is defined, we can add something to MRTK's configuration. See #11431 from more details.