Ensure that rotation is smoothed when SmoothLerpToTarget is True. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SmoothLerpToTarget is true, the target value that we are interpolating to should be lerpTargetLocalRotation. For example, on line 320 we compute angleDiff assuming the new angle we are going to is lerpTargetLocalRotation. However, when performing the actual Quaternion.Slerp computation, we are currently setting the target as targetRotation. Fix this by setting the target in the Quaternion.Slerp call to lerpTargetRotation and lerpTargetLocalRotation.
NeerajW
added a commit
that referenced
this pull request
Feb 16, 2016
Ensure that rotation is smoothed when SmoothLerpToTarget is True.
NeerajW
pushed a commit
that referenced
this pull request
Sep 26, 2016
Merge latest from MSFT-master
darax
pushed a commit
that referenced
this pull request
Oct 27, 2016
spatial sound - Added spread,spatial,reverb curve to UAudioManager
NeerajW
pushed a commit
that referenced
this pull request
Jul 19, 2017
StephenHodgson
pushed a commit
that referenced
this pull request
Sep 26, 2017
Zod-
pushed a commit
to Zod-/MixedRealityToolkit-Unity
that referenced
this pull request
Oct 10, 2017
Minor fixes so tests will run again
keveleigh
pushed a commit
that referenced
this pull request
Dec 11, 2017
Removing Editor detection in favor of Unity APIs
NeerajW
pushed a commit
that referenced
this pull request
Feb 13, 2018
…vement Updating Singleton PR with namespace changes
cre8ivepark
pushed a commit
that referenced
this pull request
Mar 2, 2018
Add comments and minor code cleanup to TwoHandManipulatable.cs
SimonDarksideJ
pushed a commit
that referenced
this pull request
Apr 9, 2018
TapToPlace: extends the usage of collider to place objects (#1854)
david-c-kline
pushed a commit
that referenced
this pull request
May 7, 2018
Updated Bit ops in Two Handed Manipulatable.
keveleigh
pushed a commit
that referenced
this pull request
Aug 24, 2018
Properly initialize the field value and set the setting back to the profile
SimonDarksideJ
pushed a commit
that referenced
this pull request
Sep 10, 2018
Some CRs for your pull request.
cre8ivepark
referenced
this pull request
in johnppella/MixedRealityToolkit-Unity
Oct 31, 2018
Bounding Box Port CRs
This was referenced Jun 7, 2019
chrisfromwork
pushed a commit
that referenced
this pull request
Jun 18, 2019
Fix mobile camera transform + marker visual & marker visual detector localizers
wiwei
added a commit
that referenced
this pull request
Jul 29, 2019
…ycast functionality. #4917 This change adds an extension point to the IMixedRealityRaycastProvider to allow for customizing how the GraphicsRaycast works. This allows for clients to customize the priority order of raycast results. The goal here was to make it possible for clients to change the order of RaycastResultComparer::Comparers, so the changes involved: 1) Adding the GraphicsRaycast function to IMixedRealityRaycastProvider. 2) Updating RaycastResultComparer's Comparers comparison functions so that they can be referenced in subclasses. 3) Updating the default implementation to do exactly what it does today. Note that in theory it would be possible to accomplish this by just doing #1 (this would require callers to do a bunch of duplicated work, so I opted to do #2-#3 as well)
thalbern
pushed a commit
that referenced
this pull request
Dec 3, 2019
Update to current Mrtk development
keveleigh
pushed a commit
that referenced
this pull request
Dec 5, 2019
…DataProvider Updates for test/doc failures in "Generic Service in DataProvider"
provencher
referenced
this pull request
in provencher/MixedRealityToolkit-Unity
Feb 15, 2020
Update MRTK dev branch
david-c-kline
pushed a commit
that referenced
this pull request
Apr 2, 2020
Dialog updates - design update to match HoloLens 2 shell. Example scene updates.
keveleigh
pushed a commit
that referenced
this pull request
Nov 10, 2020
Cameron-Micka
added a commit
to Cameron-Micka/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 29, 2021
…: Incompatible min precision type for operand microsoft#1 of opcode microsoft#29 (counts are 1-based). Expected int or uint. (on gles) - Removing hard to read IF step macro.
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 23, 2023
…mples-#11484 Mrh3 12 text to speech examples microsoft#11484
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
…mples-#11484 Mrh3 12 text to speech examples microsoft#11484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SmoothLerpToTarget is true, the target value that we are
interpolating to should be lerpTargetLocalRotation. For example, on line
320 we compute angleDiff assuming the new angle we are going to is
lerpTargetLocalRotation.
However, when performing the actual Quaternion.Slerp computation, we are
currently setting the target as targetRotation. Fix this by setting the
target in the Quaternion.Slerp call to lerpTargetRotation and
lerpTargetLocalRotation.