Added option to only have slider sounds play during manipulation #10081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogPodge
changed the title
keveleigh
approved these changes
Jul 14, 2021
|
Is it possible to write tests for this? |
Zee2
approved these changes
Jul 14, 2021
Seems a tad cumbersome since the specific sounds that are played are all private. Since the sounds are also OneShot's too, I imagine that it'd be a bit flakey to tell if the audio source is currently playing on the exact frame we expect it to. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added option to only play slider sounds during manipulation. When enabled, a flag is flipped on when the slider is being manipulated, which allows the sounds to play. This ensures that the sound only plays during manipulation, and not when the value is modified via scripts.
Changes