Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handling IOSMinOSVersion in different cultures #10178

Merged
merged 4 commits into from
Aug 31, 2021
Merged

Correctly handling IOSMinOSVersion in different cultures #10178

merged 4 commits into from
Aug 31, 2021

Conversation

marek-stoj
Copy link
Contributor

Overview

Using CultureInfo.InvariantCulture for Configurations.IOSMinOSVersion because some cultures use other decimal separators than a dot ('.'). For example, in pl-PL it is a comma (',').

Using CultureInfo.InvariantCulture for Configurations.IOSMinOSVersion because some cultures use other decimal separators than a dot ('.'). For example, in pl-PL it is a comma (',').
…urator

Correctly handling IOSMinOSVersion in different cultures
@keveleigh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh
Copy link
Contributor

/azp run

@keveleigh keveleigh added this to the MRTK 2.8.0 milestone Aug 31, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@keveleigh keveleigh merged commit 90f3152 into microsoft:main Aug 31, 2021
@keveleigh
Copy link
Contributor

Thanks for fixing this up!

keveleigh pushed a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…0178)

* Correctly handling IOSMinOSVersion in different cultures

Using CultureInfo.InvariantCulture for Configurations.IOSMinOSVersion because some cultures use other decimal separators than a dot ('.'). For example, in pl-PL it is a comma (',').

* Fixed a NullReferenceException issue in LinePointer
keveleigh pushed a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…0178)

* Correctly handling IOSMinOSVersion in different cultures

Using CultureInfo.InvariantCulture for Configurations.IOSMinOSVersion because some cultures use other decimal separators than a dot ('.'). For example, in pl-PL it is a comma (',').

* Fixed a NullReferenceException issue in LinePointer
keveleigh pushed a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…0178)

* Correctly handling IOSMinOSVersion in different cultures

Using CultureInfo.InvariantCulture for Configurations.IOSMinOSVersion because some cultures use other decimal separators than a dot ('.'). For example, in pl-PL it is a comma (',').

* Fixed a NullReferenceException issue in LinePointer
keveleigh pushed a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…0178)

* Correctly handling IOSMinOSVersion in different cultures

Using CultureInfo.InvariantCulture for Configurations.IOSMinOSVersion because some cultures use other decimal separators than a dot ('.'). For example, in pl-PL it is a comma (',').

* Fixed a NullReferenceException issue in LinePointer
keveleigh pushed a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
…0178)

* Correctly handling IOSMinOSVersion in different cultures

Using CultureInfo.InvariantCulture for Configurations.IOSMinOSVersion because some cultures use other decimal separators than a dot ('.'). For example, in pl-PL it is a comma (',').

* Fixed a NullReferenceException issue in LinePointer
keveleigh pushed a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 8, 2021
…0178)

* Correctly handling IOSMinOSVersion in different cultures

Using CultureInfo.InvariantCulture for Configurations.IOSMinOSVersion because some cultures use other decimal separators than a dot ('.'). For example, in pl-PL it is a comma (',').

* Fixed a NullReferenceException issue in LinePointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants