Added See-It Say-It Labels To Buttons #11466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenaklein-msft
requested review from
AMollis,
shaynie and
srinjoym
as code owners
shaynie
approved these changes
Apr 14, 2023
AMollis
changed the title
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
- Adds a SeeItSayItLabelEnabler script which enables See-It Say-It labels at runtime, if voice commands are enabled for a button and the speech and input packages are installed. - Adds anims to uxcomponents and uxcomponents.noncanvas, and adds a StateVisualizer component to canvas and non-canvas See-It Say-It label prefabs, to show See-It Say-It label on active hover. - Updates the canvas and non-canvas button prefabs (Empty Button and Pressable Button_128x32mm_TextOnly) to add See-It Say-It Labels (disabled by default) and the SeeItSayItLabelEnabler. - Updates the SeeItSayIt Example scene to use the SeeItSayItLabelEnabler component to enable labels at runtime. - Adds unit tests for canvas and non-canvas label prefabs, as well as SeeItSayItLabelEnabler script. - Adds null checks to StateVisualizer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a SeeItSayItLabelEnabler script which enables SeeItSayIt labels at runtime, if voice commands are enabled for a button and the speech and input packages are installed.
Adds anims to uxcomponents and uxcomponents.noncanvas, and adds a StateVisualizer component to both of the label prefabs, to show SeeItSayIt label on active hover.
Updates the Canvas and Non-Canvas button prefabs (Empty Button and Pressable Button_128x32mm_TextOnly) to add SeeItSayItLabels (disabled by default) and the SeeItSayItLabelEnabler.
Updates the SeeItSayIt sample scene to use the SeeItSayItLabelEnabler component to enable labels at runtime.
Adds unit tests for canvas and non-canvas label prefabs, as well as SeeItSayItLabelEnabler script.
Adds null checks to StateVisualizer
Changes