Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HoloToolkit PlaneFinding doesn't build on latest Windows SDK Visual Studio Update 2 #7

Closed
ForrestTrepte opened this issue May 19, 2016 · 1 comment
Closed

HoloToolkit PlaneFinding doesn't build on latest Windows SDK Visual Studio Update 2 #7

ForrestTrepte opened this issue May 19, 2016 · 1 comment
Assignees
@ForrestTrepte

Comments

@ForrestTrepte
Copy link
Contributor

  1. Install Visual Studio Update 2 with its default Windows SDK version.
  2. Open PlaneFinding.sln.
  3. Build Solution

result: C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Platforms\Win32\PlatformToolsets\v140\Toolset.targets(34,5): error MSB8036: The Windows SDK version 10.0.10502.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".
expected: Builds successfully.

Following the directions in the error to "Retarget solution" didn't fix the problem. I found a way to update the version by manually editing the project file. Stay tuned. I'll make a pull request with this fix and get feedback on whether we should roll forward to this version and whether my fix looks correct.
@ForrestTrepte ForrestTrepte self-assigned this May 19, 2016
ForrestTrepte added a commit to ForrestTrepte/HoloToolkit that referenced this issue May 19, 2016
@ForrestTrepte
upgrade Windows SDK version from 10.0.10502.0 to 10.0.10586.0
b758bc2 
Addresses: microsoft#7

I am also changing the tag from TargetPlatformVersion to WindowsTargetPlatformVersion. I'm not sure of the difference, but in Visual Studio when I used the "Retarget solution" command it added a WindowsTargetPlatformVersion tag, but that didn't work while there was still an older TargetPlatformVersion tag. Other projects don't seem to use the TargetPlatformVersion tag, so hopefully WindowsTargetPlatformVersion is the correct tag to use. Please let me know if this seems incorrect.
@ForrestTrepte ForrestTrepte mentioned this issue May 20, 2016
Merged
@angelaHillier
Copy link
Contributor

Your fix has now been merged into Main.

@ForrestTrepte ForrestTrepte mentioned this issue May 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ForrestTrepte ForrestTrepte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@angelaHillier @ForrestTrepte