Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Windows SDK version from 10.0.10502.0 to 10.0.10586.0 #8

Conversation

ForrestTrepte
Copy link
Contributor

Addresses #7

I am also changing the tag from TargetPlatformVersion to WindowsTargetPlatformVersion. I'm not sure of the difference, but in Visual Studio when I used the "Retarget solution" command it added a WindowsTargetPlatformVersion tag, but that didn't work while there was still an older TargetPlatformVersion tag. Other projects don't seem to use the TargetPlatformVersion tag, so hopefully WindowsTargetPlatformVersion is the correct tag to use. Please let me know if this seems incorrect.

Addresses: microsoft#7

I am also changing the tag from TargetPlatformVersion to WindowsTargetPlatformVersion. I'm not sure of the difference, but in Visual Studio when I used the "Retarget solution" command it added a WindowsTargetPlatformVersion tag, but that didn't work while there was still an older TargetPlatformVersion tag. Other projects don't seem to use the TargetPlatformVersion tag, so hopefully WindowsTargetPlatformVersion is the correct tag to use. Please let me know if this seems incorrect.
@msftclas
Copy link

Hi @ForrestTrepte, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Forrest Trepte). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

<ProjectGuid>{C656849B-7572-451D-BF74-73F78FE50D37}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>PlaneFindingEditor</RootNamespace>
<TargetPlatformVersion>10.0.10502.0</TargetPlatformVersion>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me as if this is the only line that actually changed. I am committing with Unix-style line endings and checking out with Windows-style CRLF endings. This is the recommended setting from git.

Perhaps this file contained Windows line endings and that is why it shows as every line having changed?

@angelaHillier angelaHillier merged commit 5410845 into microsoft:master May 20, 2016
@angelaHillier
Copy link
Contributor

Thanks for the fix, Forrest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants