Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user/pass mismatch when adding a source #161

Closed
wants to merge 2 commits into from
Closed

Fix user/pass mismatch when adding a source #161

wants to merge 2 commits into from

Conversation

yuvalyaron
Copy link
Collaborator

Fixes #153

  • Fixed the mismatch, now the user/password match the user/password in the connection string.
  • Moved the username postgres_admin to a variable

tamirkamara
tamirkamara reviewed Jun 26, 2023
View reviewed changes
infra/main.bicep Outdated
@@ -293,7 +296,7 @@ resource deplymentAddDataSource 'Microsoft.Resources/deploymentScripts@2020-10-0
environmentVariables: [
{
name: 'CONNECTION_STRING'
secureValue: 'jdbc:postgresql://${atlasDatabase.outputs.postgresServerFullyQualifiedDomainName}:5432/${postgresOMOPCDMDatabaseName}?user=postgres_admin&password=${postgresOMOPCDMPassword}&sslmode=require'
secureValue: 'jdbc:postgresql://${atlasDatabase.outputs.postgresServerFullyQualifiedDomainName}:5432/${postgresOMOPCDMDatabaseName}?user=${postgresOMOPCDMUserName}&password=${postgresOMOPCDMPassword}&sslmode=require'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is being defined multiple time as well as persisted to KV. maybe you can consolidate all to use the output of the module where it is being persisted at?

@yuvalyaron yuvalyaron changed the base branch from v2 to main June 26, 2023 13:15
@yuvalyaron yuvalyaron closed this Jun 26, 2023
@yuvalyaron yuvalyaron reopened this Jun 26, 2023
@yuvalyaron yuvalyaron changed the base branch from main to v2 June 26, 2023 13:19
@yuvalyaron yuvalyaron closed this Jun 26, 2023
@yuvalyaron yuvalyaron deleted the yuvalyaron/153-fix-user-pass-mismatch branch June 26, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User/Pass mismatch when adding a source
2 participants
@yuvalyaron @tamirkamara