This repository has been archived by the owner on Dec 22, 2020. It is now read-only.
Fix #53 Upgrade to be able to set token expiration #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-hamud
approved these changes
Mar 8, 2017
README.md
Outdated
|
|
||
| > Examples | ||
|
|
||
| To create a Power BI embed token with specific user and one role: | ||
|
|
||
| `powerbi create-embed-token -c <collection> -k <key>...key -w 06640...744d8f10 -r 07842...e30 -u "Ali Hamud" --roles "Developer"` | ||
| `powerbi create-embed-token -c <collection> -k <key>...key -w 06640...744d8f10 -r 07842...e30 -u "Ali Hamud" --roles "Developer" -e "2020-01-01"` | ||
|
|
There was a problem hiding this comment.
please give example of a full time here:
03-02-2018 15:03:54 UTC
There was a problem hiding this comment.
Thank you for your review and sorry for the delay. I fixed an example to a full-time.
| @@ -51,7 +52,8 @@ export default function CliCreateEmbedToken() { | |||
| if (!(settings.report || settings.dataset)) { | |||
| return cli.error('Either reportId or datasetId must be set'); | |||
| } | |||
| token = powerbi.PowerBIToken.createReportEmbedToken(settings.collection, settings.workspace, settings.report, settings.dataset, settings.scopes, settings.username, settings.roles); | |||
| let expiration = settings.expiration ? new Date(settings.expiration) : void 0; | |||
| token = powerbi.PowerBIToken.createReportEmbedToken(settings.collection, settings.workspace, settings.report, settings.dataset, settings.scopes, settings.username, settings.roles, expiration); | |||
There was a problem hiding this comment.
why void 0?
please sett null
There was a problem hiding this comment.
expiration parameter of createReportEmbedToken should be Date object or no value (undefined, void 0). In fact, expiration is initialized to null by 'createReportEmbedToken' if it's undefined, but it's better to observe function parameter type, IMHO.
ali-hamud
approved these changes
Apr 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a feature of setting expiration to cli-create-embed-token.