26841 Update Sample Bar Chart to support high contrast mode #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guy-Moses
reviewed
Jun 27, 2018
| dist | ||
| .api |
There was a problem hiding this comment.
Thanks for cleanup and adding this
Guy-Moses
reviewed
Jun 27, 2018
|
|
||
| barChartDataPoints.push({ | ||
| category: category.values[i] + '', | ||
| color, | ||
| strokeColor, |
There was a problem hiding this comment.
Please use thicker strokes for high-contrast mode (native visuals use stroke-width 2)
Guy-Moses
reviewed
Jun 27, 2018
src/barChart.ts
Outdated
| : null; | ||
| } | ||
|
|
||
| function getAxisTextFillColor( |
There was a problem hiding this comment.
I can't spot the bug here, but when testing the visual, axis text is always black, it should be foreground color.
There was a problem hiding this comment.
done. Issue was related to applying color instead of fill
Guy-Moses
reviewed
Jun 27, 2018
src/barChart.ts
Outdated
| }) | ||
| .style('fill-opacity', viewModel.settings.generalView.opacity / 100); | ||
| .style({ | ||
| 'fill-opacity': viewModel.settings.generalView.opacity / 100, |
There was a problem hiding this comment.
Please add stroke opacity for highlight indication in high-contrast mode (native use stroke-opacity 0.4)
There was a problem hiding this comment.
done. Thanks for your notes.
AviSander
approved these changes
Jun 27, 2018
Guy-Moses
approved these changes
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.