Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infura Ethereum (Independent Publisher) #1410

Merged
merged 8 commits into from
Mar 8, 2022
Merged

Conversation

sebastianzolg
Copy link
Contributor

@sebastianzolg sebastianzolg commented Feb 1, 2022


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

Important: Our certification engineer, Srikanth, is currently on emergency leave. Please expect a delay with your PR. He will return January 31st, 2022. We apologize for any inconveniences.

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Sample Flow

image
image

Test Action Results

image

@sebastianzolg sebastianzolg requested a review from a team as a code owner February 1, 2022 08:26
@ghost
Copy link

ghost commented Feb 1, 2022

CLA assistant check
All CLA requirements met.

@schabungbam
Copy link
Contributor

schabungbam commented Feb 1, 2022

Few comments--
Given that the connector using script, it would be good to add some doc to describe how it is implemented.

Q: Why do we need to transform the request for Get Balance?
It seems overly complex. The connector should simplify the experience for the end user. It seems we are asking the user to specify an array of object (Address, Block), and the connector is only using the first element of the array. This is what I think the payload looks like:

{
   "jsonrpc": "2.0",
   "method": "eth_getBalance",
   "params": [
      {
         "Address": "stringvalue",
         "Block": "string-enum"
      }
   ]
}

Instead, suggest that we ask the user to specify a simpler format, and handle the complexity in the connector. Suggest we change the input to something simpler like:

{
   "jsonrpc": "2.0",
   "method": "eth_getBalance",
   // "params": {  // optional - if we use this, make this required
         "Address": "stringvalue",   // required
         "Block": "string-enum"     // required, a default value would be nice
   // }
}

Very neat, overall! 👍

@sebastianzolg
Copy link
Contributor Author

@schabungbam Thank you for your kind feedback! Those are good points. Give me a few days to address them.
—Sebastian

@natalie-pienkowska
Copy link
Contributor

Hi @sebastianzolg just wanted to let you know that we have a delay in our certification pipeline due to a family emergency. We will let you know when we can review your PR shortly.

@sebastianzolg
Copy link
Contributor Author

Dear @natalie-pienkowska, there is absolutely no need to rush! Please, everyone, take the time to overcome this emergency. There are more important things than a custom connector. I wish you all the best. Take care, everyone!

@sebastianzolg
Copy link
Contributor Author

Hello @schabungbam, again, thank you very much for your comments and thoughts. Please see my answer on the Project Id here.

Regarding simplifying the eth_getBalance, I followed your advice and removed the need to wrap the input in an array. Please note that the Infura API still expects a flat array for this case. I've improved the script.csx to generalize this approach. Also, I think this approach is easy to maintain and allows me to add more calls in the future without doing too much transformation. The UX is good enough, IMO. I've also added a default value for the Block parameter.

Furthermore, I did improve the README.md and added a section to explain transformation code and the route policy.

Let me know what you think, and see what @natalie-pienkowska + team has to say about it once everyone is back to work.

—Sebastian

@sriyen-msft sriyen-msft added needs:partner-attention Validation phase Connector is being validated by Microsoft. labels Feb 16, 2022
@sebastianzolg
Copy link
Contributor Author

Hello @sriyen-msft,

Thanks for the review. I've updated the content accordingly. Please have a look and let me know if there is anything else I need to change.

Thank you.
—Sebastian

@sebastianzolg
Copy link
Contributor Author

Hello @sriyen-msft, I hope you do well. Is there any update on this? What are the next steps, and do you need anything else from me? Thank you.

@sriyen-msft sriyen-msft added certification-in-progress and removed Validation phase Connector is being validated by Microsoft. needs:partner-attention labels Feb 22, 2022
@sriyen-msft
Copy link
Contributor

[[certify-connector]]

@sriyen-msft
Copy link
Contributor

@sebastianzolg We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments which typically takes 3-4 weeks. Please note that the documentation for your connector will not be generated until the deployment process is in the final steps. Thanks.

@Amjed-Ayoub
Copy link
Contributor

Dear partner,

We apologize for the delay you might be experiencing while we are working on a high volume of connector requests. Rest assured that we are doing everything we can to address this volume. We are taking measures like improving our processes and hiring additional team members to guarantee resolving your connector requests in a timely manner.

Please let us know if you have any questions in the meantime.

@sriyen-msft
Copy link
Contributor

@sebastianzolg Sorry for the delay in response, your connector is now in production deployment and reached to Asia region, and it would be completed and available in all the production regions by Friday 11th February 2022. Please let us know if you have any questions, Thanks.

@sriyen-msft
Copy link
Contributor

@sebastianzolg Congratulations! The deployment of your connector and documentation page is now complete, We have a short survey on the connector certification process that we would like for you to complete. Your feedback is appreciated and will help us improve the program, Thanks.

@sriyen-msft sriyen-msft merged commit f891a6c into microsoft:dev Mar 8, 2022
@sriyen-msft
Copy link
Contributor

@sebastianzolg We have found that the deployment of your connector had issues at our end. We have fixed it and redeploying your connector to all the production regions. Please allow us some time to get back to you with ETA for completing the deployment. We will keep you posted with the updates. Apologies for the inconvenience.
@natalie-pienkowska @Amjed-Ayoub FYI

johannesh-recordedfuture pushed a commit to recordedfuture/PowerPlatformConnectors that referenced this pull request Mar 28, 2022
* Adds Infura Ethereum Connector v1

* Passing Swagger Verification

* Adds README.md

* Improved security and transformation docs

* Simplified usage of eth_getBalance method

* Update README.md to match template

* Remove empty properties from swagger.json

Co-authored-by: Sebastian Zolg <sebastian.zolg@swisscom.com>
@sriyen-msft
Copy link
Contributor

@sebastianzolg We have deployed your connector to Preview and are able to create a connection as per the instructions mentioned in the readme.md and test the connector. Can you please test the connector in the Preview region and let us know if we can go ahead and queue up the connector for production deployment.

Docs - Create an environment in the Preview region

image

@sebastianzolg
Copy link
Contributor Author

@sriyen-msft Good day! The connector is working inside a preview environment. Please go ahead and queue up the connector for production deployment. Thanks a lot for your help and support.
—Sebastian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants