Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved download and create connector experience #38

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Improved download and create connector experience #38

merged 1 commit into from
Jun 25, 2019

Conversation

mamurshe
Copy link
Collaborator

@mamurshe mamurshe commented Jun 6, 2019

  • Specified directory during download is created when doesn't exists, but no extra sub-drectory with connector_id is created.
  • A sub-drectory with connector_id is still created when destination parameter isn't specified during download.
  • A --overwrite option is added during download. When this is parameter specified ALL destination file will be overwritten. Customer will be prompted for file replacement when this parameter is not specified.
  • A settings file is now written after the create operation.
  • A --overwriter-setting option is added for create. When this is parameter specified the settings file will be overwritten. Customer will be prompted for settings file replacement when this parameter is not specified.

This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

- Specified directory during download is created when doesn't exists, but no extra sub-drectory with connector_id is created.
- A sub-drectory with connector_id is still created when destination parameter isn't specified during download.
- A --overwrite option is added during download. When this is parameter specified ALL destination file will be overwritten. Customer will be prompted for file replacement when this parameter is not specified.
- A settings file is now written after the create operation.
- A --overwriter-setting option is added for create. When this is parameter specified the settings file will be overwritten. Customer will be prompted for settings file replacement when this parameter is not specified.
@mamurshe mamurshe requested a review from a team as a code owner June 6, 2019 20:51
@mamurshe mamurshe merged commit ba2cbef into microsoft:master Jun 25, 2019
@mamurshe mamurshe deleted the dir-enhancements branch July 18, 2019 23:41
sriharip-docusign added a commit to release-docusign/PowerPlatformConnectors that referenced this pull request Jul 19, 2023
Reverse Integrate release-docusign -> sriharip-docusign
harshitav-docusign added a commit to release-docusign/PowerPlatformConnectors that referenced this pull request Oct 23, 2023
…and swagger validation errors fixed:ge pull request microsoft#38 from harshitav-docusign/swagger_updates

Fixed swagger errors. Remove envelope Id from the description
vmanoharas pushed a commit that referenced this pull request Oct 25, 2023
* FLOW-282: Add unique tab label for all tab types

* FLOW-294: Replace the dropdown for update ecf by text and deprecate v2 version of create from template action

* The 'summary' value goes over the character limit '80'. Shortened it.

* FLOW-292: witness "name" should not be displayed as a required field

* Don't show V2 in the deprecated version of create envelope using template

* FLOW-271: Power Automate: Unable to turn off and turn back on, a flow, that uses connect trigger

* Adding delete hook for v3 trigger

* FLOW-312 - Value property needs to be part the output field in Get envelope custom field action

* FLOW-338: template prefill : in create from template action , add support for email subject and body

* UI is added

* Phone and SMS recipients added to the solution

* Add all the signer properties to the output

* Add + to the trip character array

* Indendation fixed

* Implement feedback

* FLOW-343: update recipient action
* support SMS delivery
* support all recipient types

* remove the extra forward slash

* Implemented GetRecipientFields for all the recipient types

* Remove signers array

* Remove double referencing. Add signer object to an array

* remove the extra blank line

* FLOW-345: DocGen: Get document id given a document name

* Code optimization implemented

* UI of the GetTabValues

* Lower case the labels

* Updated the custom action title

* Updated the operationId

* Fix bug around no-match found

* Convert token to string before matching

* Get Tab Info method implementation added

* Validation added to check if tab label provided is missing

* UI is added. Script needs little work

* Removed the string conversion tabLabel

* able to output 1 tab

* FLOW-348: List Templates Action for Power Automate
Expose it , so that Microsoft's maker / c2 experience can leverage.

* Fix the meal db connector issue

* no message

* Working code generating output. The body data needs to be added

* Document details are returned

* FLOW-377: c2: Sender/Signer can create an envelope from a template using a variable for the template ID

* Add validation message

* Rewrite request url for /envelopes/createFromTemplateNoRecipients endpoint

* Operation Id updated

* Add the shortform to create array of objects

* Get template documents action added

* Updated the description

* Removed the x-ms-visibility property

* fixed the indendation

* FLOW-374: c2 get document tabs from envelope

* Update the schema for Tab with additional properties

* Recipient tabs test case added

* Add validation statement

* Removing the duplicate code

* UI fix

* Get template document tabs added

* ListEnvelopeDocumentFields custom action added

* Update UI

* FLOW-365: c2: update envelope prefill tabs

* Rename field identifier to match the internal names

* Fix description grammar

* Add a field to indicate whether a tab is prefill or not for the get action

* UI added

* FLOW-346: DocGen - Get merge fields

* UpdateRecipientTabs added

* Removed StaticResponse

* REmoved StaticResponseForTabTypesWithValues

* Remove the ms-visibility

* FLOW-347: DocGen: Update merge fields

* Add a check if the email token exists in the signer objects

* Optimize the if statement

* Bump the build number for C2/R2 release

* Add back the removed Meal DB/Readme.md file

* FLOW-392: Get document id action should return both id and guid

* Expose template id in the output of create envelope using template actions

* Add GetEnvelopeDocumentFields custom method

* Added delivery phone and SMS phone options

* formating the code

* convert template input to a template dropdown

* Rename actions to make it more readable for the user

* Update doc gen action name

* identiti verification added

* Fix typo in "List documents from an envelope" action name

* DS1002 R2 and C2 Release for DocuSign Connector
Porting changes from DocuSign Demo -> DocuSign Connector

* FLOW-427: Support "Transform PDF fields to DocuSign tabs" in Power Automate

* Sales copilot custom actions are added

(cherry picked from commit 90c0601)

* Update title with lower case

(cherry picked from commit 9b6111c)

* Release candidate DS1003 created

* Build number updated

* Transfering DocuSign demo code to DocuSign prod connector

* Porting changes from DocuSign demo dev to MSFlow.DS1003.10.17.2023

* Fix the title and description specific to Prod

* Build number updated

* cherry pick the swagger fixes to the release branchemoved envelopeId and swagger validation errors fixed:ge pull request #38 from harshitav-docusign/swagger_updates

Fixed swagger errors. Remove envelope Id from the description

* swagger validation errors fixed. EnvelopeId removed

* Resolved conflicts

* NLP changes added

* Validated with paconn tool

---------

Co-authored-by: Srihari Padmanabhan <90345666+sriharip-docusign@users.noreply.github.com>
Co-authored-by: Srihari Padmanabhan <srihari.padmanabhan@docusign.com>
Co-authored-by: Angel Garcia Reyes <105454462+angelga-docusign@users.noreply.github.com>
Co-authored-by: Mahbub Murshed <48570820+mamurshe@users.noreply.github.com>
harshitav-docusign added a commit to release-docusign/PowerPlatformConnectors that referenced this pull request Oct 31, 2023
…uest microsoft#38 from harshitav-docusign/swagger_updates

Fixed swagger errors. Remove envelope Id from the description
vmanoharas pushed a commit that referenced this pull request Oct 31, 2023
* The 'summary' value goes over the character limit '80'. Shortened it.

* FLOW-292: witness "name" should not be displayed as a required field

* Don't show V2 in the deprecated version of create envelope using template

* FLOW-271: Power Automate: Unable to turn off and turn back on, a flow, that uses connect trigger

* Adding delete hook for v3 trigger

* FLOW-312 - Value property needs to be part the output field in Get envelope custom field action

* FLOW-338: template prefill : in create from template action , add support for email subject and body

* UI is added

* Phone and SMS recipients added to the solution

* Add all the signer properties to the output

* Add + to the trip character array

* Indendation fixed

* Implement feedback

* FLOW-343: update recipient action
* support SMS delivery
* support all recipient types

* remove the extra forward slash

* Implemented GetRecipientFields for all the recipient types

* Remove signers array

* Remove double referencing. Add signer object to an array

* remove the extra blank line

* FLOW-345: DocGen: Get document id given a document name

* Code optimization implemented

* UI of the GetTabValues

* Lower case the labels

* Updated the custom action title

* Updated the operationId

* Fix bug around no-match found

* Convert token to string before matching

* Get Tab Info method implementation added

* Validation added to check if tab label provided is missing

* UI is added. Script needs little work

* Removed the string conversion tabLabel

* able to output 1 tab

* FLOW-348: List Templates Action for Power Automate
Expose it , so that Microsoft's maker / c2 experience can leverage.

* Fix the meal db connector issue

* no message

* Working code generating output. The body data needs to be added

* Document details are returned

* FLOW-377: c2: Sender/Signer can create an envelope from a template using a variable for the template ID

* Add validation message

* Rewrite request url for /envelopes/createFromTemplateNoRecipients endpoint

* Operation Id updated

* Add the shortform to create array of objects

* Get template documents action added

* Updated the description

* Removed the x-ms-visibility property

* fixed the indendation

* FLOW-374: c2 get document tabs from envelope

* Update the schema for Tab with additional properties

* Recipient tabs test case added

* Add validation statement

* Removing the duplicate code

* UI fix

* Get template document tabs added

* ListEnvelopeDocumentFields custom action added

* Update UI

* FLOW-365: c2: update envelope prefill tabs

* Rename field identifier to match the internal names

* Fix description grammar

* Add a field to indicate whether a tab is prefill or not for the get action

* UI added

* FLOW-346: DocGen - Get merge fields

* UpdateRecipientTabs added

* Removed StaticResponse

* REmoved StaticResponseForTabTypesWithValues

* Remove the ms-visibility

* FLOW-347: DocGen: Update merge fields

* Add a check if the email token exists in the signer objects

* Optimize the if statement

* Bump the build number for C2/R2 release

* Add back the removed Meal DB/Readme.md file

* FLOW-392: Get document id action should return both id and guid

* Expose template id in the output of create envelope using template actions

* Add GetEnvelopeDocumentFields custom method

* Added delivery phone and SMS phone options

* formating the code

* convert template input to a template dropdown

* Rename actions to make it more readable for the user

* Update doc gen action name

* identiti verification added

* Fix typo in "List documents from an envelope" action name

* DS1002 R2 and C2 Release for DocuSign Connector
Porting changes from DocuSign Demo -> DocuSign Connector

* FLOW-427: Support "Transform PDF fields to DocuSign tabs" in Power Automate

* Sales copilot custom actions are added

(cherry picked from commit 90c0601)

* Update title with lower case

(cherry picked from commit 9b6111c)

* Release candidate DS1003 created

* Build number updated

* cherry picking from harshita devMerge pull request #37 from harshitav-docusign/BugBashFixes

SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting

* Merged bug fixesMerge pull request #36 from harshitav-docusign/recordId_issue

RecordId and OrgUrl filters fixed. Activities and Records render latest first

* Merge pull request #37 from harshitav-docusign/BugBashFixes

SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting

* Adding back PPDF tranformation fields

* Fix spacing issues

* Transfering DocuSign demo code to DocuSign prod connector

* Porting changes from DocuSign demo dev to MSFlow.DS1003.10.17.2023

* Fix the title and description specific to Prod

* Corrected the swagger. Removed envelopeId from responseMerge pull request #38 from harshitav-docusign/swagger_updates

Fixed swagger errors. Remove envelope Id from the description

* removed merge conflicts

* Additional properties fixed. DateTime formatted

* Added local time and additional properties

* rearranged the swagger definition

---------

Co-authored-by: Srihari Padmanabhan <90345666+sriharip-docusign@users.noreply.github.com>
Co-authored-by: Srihari Padmanabhan <srihari.padmanabhan@docusign.com>
Co-authored-by: Angel Garcia Reyes <105454462+angelga-docusign@users.noreply.github.com>
Co-authored-by: Mahbub Murshed <48570820+mamurshe@users.noreply.github.com>
vmanoharas pushed a commit that referenced this pull request Mar 13, 2024
* FLOW-292: witness "name" should not be displayed as a required field

* Don't show V2 in the deprecated version of create envelope using template

* FLOW-271: Power Automate: Unable to turn off and turn back on, a flow, that uses connect trigger

* Adding delete hook for v3 trigger

* FLOW-312 - Value property needs to be part the output field in Get envelope custom field action

* FLOW-338: template prefill : in create from template action , add support for email subject and body

* UI is added

* Phone and SMS recipients added to the solution

* Add all the signer properties to the output

* Add + to the trip character array

* Indendation fixed

* Implement feedback

* FLOW-343: update recipient action
* support SMS delivery
* support all recipient types

* remove the extra forward slash

* Implemented GetRecipientFields for all the recipient types

* Remove signers array

* Remove double referencing. Add signer object to an array

* remove the extra blank line

* FLOW-345: DocGen: Get document id given a document name

* Code optimization implemented

* UI of the GetTabValues

* Lower case the labels

* Updated the custom action title

* Updated the operationId

* Fix bug around no-match found

* Convert token to string before matching

* Get Tab Info method implementation added

* Validation added to check if tab label provided is missing

* UI is added. Script needs little work

* Removed the string conversion tabLabel

* able to output 1 tab

* FLOW-348: List Templates Action for Power Automate
Expose it , so that Microsoft's maker / c2 experience can leverage.

* Fix the meal db connector issue

* no message

* Working code generating output. The body data needs to be added

* Document details are returned

* FLOW-377: c2: Sender/Signer can create an envelope from a template using a variable for the template ID

* Add validation message

* Rewrite request url for /envelopes/createFromTemplateNoRecipients endpoint

* Operation Id updated

* Add the shortform to create array of objects

* Get template documents action added

* Updated the description

* Removed the x-ms-visibility property

* fixed the indendation

* FLOW-374: c2 get document tabs from envelope

* Update the schema for Tab with additional properties

* Recipient tabs test case added

* Add validation statement

* Removing the duplicate code

* UI fix

* Get template document tabs added

* ListEnvelopeDocumentFields custom action added

* Update UI

* FLOW-365: c2: update envelope prefill tabs

* Rename field identifier to match the internal names

* Fix description grammar

* Add a field to indicate whether a tab is prefill or not for the get action

* UI added

* FLOW-346: DocGen - Get merge fields

* UpdateRecipientTabs added

* Removed StaticResponse

* REmoved StaticResponseForTabTypesWithValues

* Remove the ms-visibility

* FLOW-347: DocGen: Update merge fields

* Add a check if the email token exists in the signer objects

* Optimize the if statement

* Bump the build number for C2/R2 release

* Add back the removed Meal DB/Readme.md file

* FLOW-392: Get document id action should return both id and guid

* Expose template id in the output of create envelope using template actions

* Add GetEnvelopeDocumentFields custom method

* Added delivery phone and SMS phone options

* formating the code

* convert template input to a template dropdown

* Rename actions to make it more readable for the user

* Update doc gen action name

* identiti verification added

* Fix typo in "List documents from an envelope" action name

* DS1002 R2 and C2 Release for DocuSign Connector
Porting changes from DocuSign Demo -> DocuSign Connector

* FLOW-427: Support "Transform PDF fields to DocuSign tabs" in Power Automate

* Sales copilot custom actions are added

(cherry picked from commit 90c0601)

* Update title with lower case

(cherry picked from commit 9b6111c)

* Release candidate DS1003 created

* Build number updated

* cherry picking from harshita devMerge pull request #37 from harshitav-docusign/BugBashFixes

SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting

* Merged bug fixesMerge pull request #36 from harshitav-docusign/recordId_issue

RecordId and OrgUrl filters fixed. Activities and Records render latest first

* Merge pull request #37 from harshitav-docusign/BugBashFixes

SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting

* Adding back PPDF tranformation fields

* Fix spacing issues

* Transfering DocuSign demo code to DocuSign prod connector

* Porting changes from DocuSign demo dev to MSFlow.DS1003.10.17.2023

* Fix the title and description specific to Prod

* Corrected the swagger. Removed envelopeId from responseMerge pull request #38 from harshitav-docusign/swagger_updates

Fixed swagger errors. Remove envelope Id from the description

* removed merge conflicts

* Additional properties fixed. DateTime formatted

* Added local time and additional properties

* Remove the Max payload exceed messaging

* Remove changes in the DocuSign folder

---------

Co-authored-by: Srihari Padmanabhan <srihari.padmanabhan@docusign.com>
Co-authored-by: Srihari Padmanabhan <90345666+sriharip-docusign@users.noreply.github.com>
Co-authored-by: Angel Garcia Reyes <105454462+angelga-docusign@users.noreply.github.com>
Co-authored-by: Mahbub Murshed <48570820+mamurshe@users.noreply.github.com>
vmanoharas pushed a commit that referenced this pull request Mar 14, 2024
* FLOW-271: Power Automate: Unable to turn off and turn back on, a flow, that uses connect trigger

* Adding delete hook for v3 trigger

* FLOW-312 - Value property needs to be part the output field in Get envelope custom field action

* FLOW-338: template prefill : in create from template action , add support for email subject and body

* UI is added

* Phone and SMS recipients added to the solution

* Add all the signer properties to the output

* Add + to the trip character array

* Indendation fixed

* Implement feedback

* FLOW-343: update recipient action
* support SMS delivery
* support all recipient types

* remove the extra forward slash

* Implemented GetRecipientFields for all the recipient types

* Remove signers array

* Remove double referencing. Add signer object to an array

* remove the extra blank line

* FLOW-345: DocGen: Get document id given a document name

* Code optimization implemented

* UI of the GetTabValues

* Lower case the labels

* Updated the custom action title

* Updated the operationId

* Fix bug around no-match found

* Convert token to string before matching

* Get Tab Info method implementation added

* Validation added to check if tab label provided is missing

* UI is added. Script needs little work

* Removed the string conversion tabLabel

* able to output 1 tab

* FLOW-348: List Templates Action for Power Automate
Expose it , so that Microsoft's maker / c2 experience can leverage.

* Fix the meal db connector issue

* no message

* Working code generating output. The body data needs to be added

* Document details are returned

* FLOW-377: c2: Sender/Signer can create an envelope from a template using a variable for the template ID

* Add validation message

* Rewrite request url for /envelopes/createFromTemplateNoRecipients endpoint

* Operation Id updated

* Add the shortform to create array of objects

* Get template documents action added

* Updated the description

* Removed the x-ms-visibility property

* fixed the indendation

* FLOW-374: c2 get document tabs from envelope

* Update the schema for Tab with additional properties

* Recipient tabs test case added

* Add validation statement

* Removing the duplicate code

* UI fix

* Get template document tabs added

* ListEnvelopeDocumentFields custom action added

* Update UI

* FLOW-365: c2: update envelope prefill tabs

* Rename field identifier to match the internal names

* Fix description grammar

* Add a field to indicate whether a tab is prefill or not for the get action

* UI added

* FLOW-346: DocGen - Get merge fields

* UpdateRecipientTabs added

* Removed StaticResponse

* REmoved StaticResponseForTabTypesWithValues

* Remove the ms-visibility

* FLOW-347: DocGen: Update merge fields

* Add a check if the email token exists in the signer objects

* Optimize the if statement

* Bump the build number for C2/R2 release

* Add back the removed Meal DB/Readme.md file

* FLOW-392: Get document id action should return both id and guid

* Expose template id in the output of create envelope using template actions

* Add GetEnvelopeDocumentFields custom method

* Added delivery phone and SMS phone options

* formating the code

* convert template input to a template dropdown

* Rename actions to make it more readable for the user

* Update doc gen action name

* identiti verification added

* Fix typo in "List documents from an envelope" action name

* DS1002 R2 and C2 Release for DocuSign Connector
Porting changes from DocuSign Demo -> DocuSign Connector

* FLOW-427: Support "Transform PDF fields to DocuSign tabs" in Power Automate

* Sales copilot custom actions are added

(cherry picked from commit 90c0601)

* Update title with lower case

(cherry picked from commit 9b6111c)

* Release candidate DS1003 created

* Build number updated

* cherry picking from harshita devMerge pull request #37 from harshitav-docusign/BugBashFixes

SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting

* Merged bug fixesMerge pull request #36 from harshitav-docusign/recordId_issue

RecordId and OrgUrl filters fixed. Activities and Records render latest first

* Merge pull request #37 from harshitav-docusign/BugBashFixes

SalesCopilot: Recipient names as array. Status to TitleCase. DocumentNLP formatting

* Adding back PPDF tranformation fields

* Fix spacing issues

* Transfering DocuSign demo code to DocuSign prod connector

* Porting changes from DocuSign demo dev to MSFlow.DS1003.10.17.2023

* Fix the title and description specific to Prod

* Corrected the swagger. Removed envelopeId from responseMerge pull request #38 from harshitav-docusign/swagger_updates

Fixed swagger errors. Remove envelope Id from the description

* removed merge conflicts

* Additional properties fixed. DateTime formatted

* Added local time and additional properties

* Remove the Max payload exceed messaging

* Remove changes in the DocuSign folder

* Remove Connect error handling to DocuSign Prod

---------

Co-authored-by: Srihari Padmanabhan <90345666+sriharip-docusign@users.noreply.github.com>
Co-authored-by: Srihari Padmanabhan <srihari.padmanabhan@docusign.com>
Co-authored-by: Angel Garcia Reyes <105454462+angelga-docusign@users.noreply.github.com>
Co-authored-by: Mahbub Murshed <48570820+mamurshe@users.noreply.github.com>
harshitav-docusign added a commit to release-docusign/PowerPlatformConnectors that referenced this pull request Sep 5, 2024
Fixed swagger errors. Remove envelope Id from the description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant