Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Freeway-Bug; Linked:Bug1641193; LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. #10766

Closed
1 task
Priyanka-Chauhan123 opened this issue Apr 16, 2021 · 11 comments
Assignees
Labels
A11y1P Accessibility team tag - PT bug has dependency on external experience which is owned by Microsoft A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11yExternal Accessibility team tag - PT bug has external dependency A11ySev2 Accessibility team tag - P2 items A11yTTValidated Accessability team tag A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility FancyZones-Editor Issue revolving the FancyZone Editor Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-FancyZones Refers to the FancyZones PowerToy Status-Blocked We can't make progress due to a dependency or issue

Comments

@Priyanka-Chauhan123
Copy link

Priyanka-Chauhan123 commented Apr 16, 2021

Microsoft PowerToys version

"0.35.0"

Running as admin

  • Yes

Area(s) with issue?

FancyZones Editor

Steps to reproduce

Test Environment:
OS: Windows 10 Build 21354.1
App version: 0.35.0
App name: PowerToys
Screen Reader: Narrator
Tool: Accessibility Insight for Windows

Pre-Requisite:

  1. Go to settings > Display settings > Set the resolution to 1280*768.
  2. Set the slider value to maximum i.e. 225% (Settings -> Ease of access -> text scaling) and Apply.

Repro Steps

  1. Launch 'PowerToys' application.
  2. Application will get open with default list item 'General' selected.
  3. Navigate to 'FancyZones' at the left side of the pane and activate it.
  4. Now navigate to 'Launch layout editor' button and activate it.
  5. FancyZones editor window will get open.
  6. Observe the issue.

User Impact: Priority-1
If any application does not support resizing of text without loss of content or functionality, the users with mild visual disabilities who scales the text instead of using the assistive technology would be impacted as zooming will not work as desired.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/sites/accessibility/_layouts/15/Doc.aspx?sourcedoc=%7B5BE8E205-7508-414C-A273-657770321DA0%7D&file=MAS%201.4.4%20%E2%80%93%20Resize%20Text.docx&wdLOR=cD434D0F2-F515-4FD8-B4DA-BA99282968ED&action=default&mobileredirect=true&cid=e8a7e0cb-a049-4c6a-b020-862f20088e4c

MAS1.4.4_Edit zone editor window not adapting resize setting.zip

✔️ Expected Behavior

FancyZones editor window should adapt 225% resize mode setting.

❌ Actual Behavior

FancyZones editor window does not adapt 225% resize mode setting.

Other Software

No response

@Priyanka-Chauhan123 Priyanka-Chauhan123 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 16, 2021
@niels9001 niels9001 added A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft Priority-1 Bug that is high priority FancyZones-Editor Issue revolving the FancyZone Editor and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Apr 16, 2021
@bmccarthynn

This comment has been minimized.

@ghost ghost added A11ySev2 Accessibility team tag - P2 items A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines labels Jul 13, 2021
@dedavis6797 dedavis6797 added this to To do in 0.47 Release via automation Aug 25, 2021
@yuyoyuppe yuyoyuppe self-assigned this Sep 13, 2021
@yuyoyuppe
Copy link
Collaborator

I believe this is blocked until we port FZE to UWP.

Ability to scale text for accessibility was initially added to UWP, but then was implemented in WPF as a patch (?).

The crucial difference between the implementations is that the text elements with FontSize property are not affected by system font scaling setting value in WPF apps, while they are affected in UWP apps. That could be tested easily by creating blank UWP/WPF apps with a following element:

<TextBlock Text="THE TEXT" FontSize="24"/>

and then changing the system-wide font scaling and observing the (lack of) changes.

In FZE we also use ui:WindowHelper.UseModernWindowStyle="True", which, among other things, sets default sizes for all TextBlock elements.

Even if we don't rely on ModernWPF default styles and reinvent them ourselves, we'll need to have a way to subscribe to font scale change events. It's easy in UWP, since it has UISettings.TextScaleFactorChanged event, but we'll have to rely on, as far as I understand, an undocumented registry value for that in WPF. Then we could use VisualTreeHelper to traverse the whole app's tree to set new FontSizes manually for all required elements. The other alternative is to inherit from TextBlock,Label... etc. standard control classes and create an event channel which would be raise events triggered by registry value changes.

I don't think any of the options described above are worth it, though I'm not a WPF expert, so I might be missing something here.

cc: @crutkas @niels9001

@niels9001
Copy link
Contributor

Yeah, I've always struggled with scaling and WPF. A lot of that solves itself by moving to WinUI / XAML Islands.

@batzen
Copy link

batzen commented Sep 30, 2021

I guess it's because the editor is missing an app.manifest file where dpi awareness has to be declared.
Example https://github.com/fluentribbon/Fluent.Ribbon/blob/develop/Fluent.Ribbon.Showcase/app.manifest
You should be able to just copy that file and replace Fluent.Ribbon with something else.

@yuyoyuppe
Copy link
Collaborator

Thanks for the suggestion! I've tried coping <application xmlns="urn:schemas-microsoft-com:asm.v3"> to our app.manifest but it didn't have any effect. I guess that's because the system option is not directly related to dpi, but to accessibility?

@batzen
Copy link

batzen commented Sep 30, 2021

Ah, my fault. I thought DPI = scale. Never used the slider for text and even forgot that it exists.

@crutkas crutkas added the Status-Blocked We can't make progress due to a dependency or issue label Oct 6, 2021
@crutkas crutkas removed this from To do in 0.49 Release Oct 6, 2021
@crutkas
Copy link
Member

crutkas commented Oct 6, 2021

Marking blocked as of now, dotnet/wpf#5405 lacks enough info for us to move forward as we don't have a way to get current scale.

@Priyanshu073 Priyanshu073 added the Area-Accessibility Issues related to accessibility label Oct 11, 2021
@crutkas crutkas added this to To do in 0.53 Release via automation Oct 28, 2021
@crutkas
Copy link
Member

crutkas commented Oct 28, 2021

revisit in 53 to see if there is a fix

@dedavis6797 dedavis6797 added A11y1P Accessibility team tag - PT bug has dependency on external experience which is owned by Microsoft A11y-1P-WPF A11yExternal Accessibility team tag - PT bug has external dependency labels Nov 3, 2021
@crutkas crutkas removed this from To do in 0.53 Release Jan 7, 2022
@Aaron-Junker Aaron-Junker added the Product-FancyZones Refers to the FancyZones PowerToy label Jan 13, 2022
@Priyanshu073
Copy link

Hello @crutkas

Kindly provide component's URL or code pen or any other details from where the UI and other components were picked such that, such that partner team can identify the component.

@crutkas
Copy link
Member

crutkas commented Jun 28, 2022

see #10766 (comment)

dotnet/wpf#5405

@Priyanka-Chauhan123 Priyanka-Chauhan123 changed the title [FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. {Linked:Bug196264}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. Aug 24, 2022
@Priyanka-Chauhan123 Priyanka-Chauhan123 changed the title {Linked:Bug196264}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. {Linked:Bug196264,LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. Aug 29, 2022
@Priyanka-Chauhan123 Priyanka-Chauhan123 changed the title {Linked:Bug196264,LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. {Linked:Bug196264, LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. Aug 29, 2022
@ghost ghost added A11y3P Accessibility team tag - PT bug has dependency on external experience owned by 3rd party and removed A11y1P Accessibility team tag - PT bug has dependency on external experience which is owned by Microsoft labels Sep 16, 2022
@crutkas crutkas added A11y1P Accessibility team tag - PT bug has dependency on external experience which is owned by Microsoft and removed A11y3P Accessibility team tag - PT bug has dependency on external experience owned by 3rd party labels Oct 5, 2022
@Priyanka-Chauhan123 Priyanka-Chauhan123 changed the title {Linked:Bug196264, LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. {Linked:Bug1641193, LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. Oct 14, 2022
@Priyanka-Chauhan123 Priyanka-Chauhan123 changed the title {Linked:Bug1641193, LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. {Freeway-Bug;Linked:Bug1641193, LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. Jan 17, 2023
@Priyanka-Chauhan123 Priyanka-Chauhan123 changed the title {Freeway-Bug;Linked:Bug1641193, LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. {Freeway-Bug;Linked:Bug1641193; LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. Jan 20, 2023
@Priyanka-Chauhan123 Priyanka-Chauhan123 changed the title {Freeway-Bug;Linked:Bug1641193; LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. {Freeway-Bug; Linked:Bug1641193; LinkedBug}[FancyZones Editor]: FancyZones editor window does not adapt 225% resize mode setting. Jan 20, 2023
@jaimecbernardo jaimecbernardo added this to To do in 0.67 Release via automation Jan 24, 2023
@Priyanshu073
Copy link

Priyanshu073 commented Jan 24, 2023

This issue is not reproducible after changing the DPI method setting(custom scaling to 200%). Hence closing this bug.

image

@WSeneca WSeneca added A11yTTValidated Accessability team tag HCL-closed labels Jan 24, 2023
@crutkas crutkas moved this from To do to Done in 0.67 Release Jan 24, 2023
@WSeneca WSeneca closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y1P Accessibility team tag - PT bug has dependency on external experience which is owned by Microsoft A11yE+D Accessibility Team tag- issues found by Accessibility E+D team at Microsoft A11yExternal Accessibility team tag - PT bug has external dependency A11ySev2 Accessibility team tag - P2 items A11yTTValidated Accessability team tag A11yWCAG Accessibility Team tag - Web Content Accessibility Guidelines Area-Accessibility Issues related to accessibility FancyZones-Editor Issue revolving the FancyZone Editor Issue-Bug Something isn't working Priority-1 Bug that is high priority Product-FancyZones Refers to the FancyZones PowerToy Status-Blocked We can't make progress due to a dependency or issue
Projects
No open projects
Development

No branches or pull requests