Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGB input in ColorPicker not working correctly #12931

Closed
1 task
martinchrzan opened this issue Aug 27, 2021 · 4 comments
Closed
1 task

RGB input in ColorPicker not working correctly #12931

martinchrzan opened this issue Aug 27, 2021 · 4 comments
Assignees
@martinchrzan
Labels
Issue-Bug Something isn't working Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Color Picker All things around the Color Picker utility Status-No recent activity no activity in the past 5 days when follow up's are needed

Comments

@martinchrzan
Copy link
Contributor

Microsoft PowerToys version

0.43.0

Running as admin

  • Yes

Area(s) with issue?

ColorPicker

Steps to reproduce

Open Color Picker editor
Click on the color to edit
Change RGB values

colorPickerRGBissue

✔️ Expected Behavior

Entered RGB values are correctly translated into HEX values and displayed color

❌ Actual Behavior

Seems like the last number (B) is being picked up incorrectly

Other Software

No response
@martinchrzan martinchrzan added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-Color Picker All things around the Color Picker utility labels Aug 27, 2021
@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Aug 27, 2021 •
edited
Loading

Can reproduce:
image
Note that the last value (red green or blue) that is changed, is the one affected. Try working right-to-left, and then keep going. It lags one visual update step.
I have no display color changes

@martinchrzan martinchrzan self-assigned this Aug 28, 2021
martinchrzan added a commit that referenced this issue Aug 28, 2021
@martinchrzan
Fixing the issue with hex textbox not being updated with the correct …
0018972 
…values from RGB boxes #12931
@martinchrzan martinchrzan mentioned this issue Aug 28, 2021
Merged
10 tasks
@Aaron-Junker Aaron-Junker added the Status-In progress This issue or work-item is under development label Aug 29, 2021
martinchrzan added a commit that referenced this issue Aug 30, 2021
@martinchrzan
Fixing the issue with HEX textbox not being updated with the correct …
46bfd2c 
…RGB values (#12936)

* Fixing the issue with hex textbox not being updated with the correct values from RGB boxes #12931

* Update current color immediately when typing in RGB boxes #11108

* added expected words into dictionary
@niels9001 niels9001 mentioned this issue Sep 29, 2021
Closed
3 tasks
@crutkas
Copy link
Member

crutkas commented Nov 12, 2021

Did this get fixed with the prior PR or is Niels looking to fix it with the UX adjustment?

@crutkas crutkas removed the Status-In progress This issue or work-item is under development label Nov 12, 2021
@stefansjfw
Copy link
Collaborator

I can reproduce this with v0.43, but not with the latest version v0.51.1. @martinchrzan could you confirm?

@stefansjfw stefansjfw added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Dec 16, 2021
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Dec 18, 2021
@ghost ghost added the Status-No recent activity no activity in the past 5 days when follow up's are needed label Dec 23, 2021
@ghost
Copy link

ghost commented Dec 23, 2021

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 5 days. It will be closed if no further activity occurs within 5 days of this comment.

@ghost ghost closed this as completed Dec 28, 2021
@ravtakhar ravtakhar mentioned this issue Jun 6, 2022
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinchrzan martinchrzan

Labels
Issue-Bug Something isn't working Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Product-Color Picker All things around the Color Picker utility Status-No recent activity no activity in the past 5 days when follow up's are needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@crutkas @martinchrzan @stefansjfw @Aaron-Junker @Jay-o-Way