-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the issue with HEX textbox not being updated with the correct RGB values #12936
Conversation
…values from RGB boxes #12931
@martinchrzan will this by any chance also fix: #11108? |
It will not, it still requires you to press enter or leave that textbox (numberbox) but I can have a look and add it here too. |
@check-spelling-bot ReportUnrecognized words, please review:
Previously acknowledged words that are now absentAccessible coc djsoref dogancelik estdir Fody ftps gmx htt inprivate itsme mfreadwrite mfuuid Nefario nitroin null nunit Radiobuttons sidepanel ulazy XSmall xunitSome files were were automatically ignoredThese sample patterns would exclude them:
You should consider adding them to:
File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use To accept these unrecognized words as correct (and remove the previously acknowledged and now absent words), run the following commands... in a clone of the git@github.com:microsoft/PowerToys.git repository
If you see a bunch of garbageIf it relates to a ... well-formed patternSee if there's a pattern that would match it. If not, try writing one and adding it to the Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines. Note that patterns can't match multiline strings. binary-ish stringPlease add a file path to the File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
|
@niels9001 Fixed that one as well now :) |
/// <returns>Validated value as per numberbox conditions, if content is invalid it returns previous value</returns> | ||
private static byte GetValueFromNumberBox(NumberBox numberBox) | ||
{ | ||
var internalTextBox = GetChildOfType<TextBox>(numberBox); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, worked as expected!
That's related to Run, right? |
Woops, i meant microsoft/microsoft-ui-xaml#3420 -> #7085 but that's for FancyZones color picking. Nevermind 🤐 |
It does not fix that, I am not suppressing any characters typed. |
Summary of the Pull Request
What is this about:
When changing values in the RGB boxes, previous value was being used to calculate HEX color (and other representations), not the current one
Also fixing the issue when current color was changed only when pressed enter of textbox lost focus.
ModernWPF numberBox is not exposing events immediately when a value changes, I have added some code that goes into its internals and grab the actual value (with validating it properly)
What is include in the PR:
See above
How does someone test / validate:
Manual check
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.