Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerToys Run] Can't find Docker Desktop #4151

Closed
Z1ni opened this issue Jun 6, 2020 · 17 comments
Closed

[PowerToys Run] Can't find Docker Desktop #4151

Z1ni opened this issue Jun 6, 2020 · 17 comments
Assignees
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@Z1ni
Copy link

Z1ni commented Jun 6, 2020

Environment

Windows build number:  10.0.18363.836
PowerToys version: 0.18.2
PowerToy module for which you are reporting the bug (if applicable): Run

Steps to reproduce

  1. Search for "Docker"/"Docker Desktop"
  2. See that only the .lnk is listed

Expected behavior

Docker Desktop can be found.

Actual behavior

Docker Desktop is not found (except the .lnk).

Screenshots

docker_lnk

@saahmedm
Copy link
Contributor

saahmedm commented Jun 9, 2020

hi, @alekhyareddy28 is this covered in #3180 ? if so, I'll close as duplicate

@alekhyareddy28
Copy link
Contributor

@saahmedm , no it is not. I think we should leave this open.

@jyuwono jyuwono added Issue-Bug Something isn't working Product-PowerToys Run Improved app launch PT Run (Win+R) Window labels Jun 9, 2020
@fquinner
Copy link

What is the criteria that decides whether or not the .lnk extension is displayed? The .lnk files do launch but the extension makes it look like "something you open" rather than "something you launch".

@crutkas
Copy link
Member

crutkas commented Jul 22, 2020

@Z1ni does this still happen with 0.19.2?

@crutkas
Copy link
Member

crutkas commented Jul 22, 2020

@fquinner the result here was from search, not the program indexer, we should be better about this at this point with 0.19.x

@crutkas crutkas added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jul 22, 2020
@Z1ni
Copy link
Author

Z1ni commented Jul 22, 2020

@crutkas On the same machine, yes. On my work machine that also has 0.19.2, Docker Desktop happily appears in the listing.
I cleared Run's app data, but it didn't change the situation. The start menu finds Docker without a problem.

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jul 22, 2020
@Z1ni
Copy link
Author

Z1ni commented Jul 22, 2020

I just installed Docker and PowerToys to my another machine and it doesn't work there either.

@crutkas
Copy link
Member

crutkas commented Jul 23, 2020

This is on 0.19.2. I installed and deleted my cache (0.20 should prevent me from needing to do that)
image

@crutkas
Copy link
Member

crutkas commented Jul 23, 2020

@alekhyareddy28 i can't reproduce this, any ideas?

@crutkas crutkas added the Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. label Jul 23, 2020
@alekhyareddy28
Copy link
Contributor

I can't think of anything off the top of my mind. @Z1ni can you please clarify if docker was installed before or after PowerToys?
Can you try a couple of things to help us debug -

  1. Clear this folder (C:\Users\USERNAME\AppData\Local\Microsoft\PowerToys\PowerToys Run) and disable and then enable powerToys run from the settings page. I understand that you had deleted it before but I want to ensure that Run was restarted after doing so.
  2. Once you do the above, if you're still facing the issue can you please share the log files. They might contain some information about why only Docker desktop is not showing up. The log files are located at - C:\Users\USERNAME\AppData\Local\Microsoft\PowerToys\PowerToys Run\Logs\1.0.0.
    Thank you!

@Z1ni
Copy link
Author

Z1ni commented Jul 26, 2020

@alekhyareddy28 All of the three computers that I've tried had Docker installed before PowerToys.
I went through the steps you listed with both of the machines that don't list Docker, and clearing and re-enabling Run did nothing.
Here are the log files for both. The laptop runs Win10 19042.330 and the desktop runs 18363.959.
laptop.txt
desktop.txt

@saahmedm
Copy link
Contributor

hi @Z1ni, can you confirm this is still happening in the latest (0.20.1), thank you for the help!

and let us know if you receive a drive detection warning in Run

@saahmedm saahmedm added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Team-Response An issue author responded so the team needs to follow up Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Aug 19, 2020
@Z1ni
Copy link
Author

Z1ni commented Aug 21, 2020

Yes, it's still happening with the same two PCs.

Both showed the drive detection warning, and because of that I checked the install location of Docker, which is in Program Files, which is indexed.

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 21, 2020
@crutkas
Copy link
Member

crutkas commented Aug 28, 2020

this shouldn't be based on indexing but the program plugin.

@crutkas crutkas added this to To do in 0.23 release via automation Aug 28, 2020
@crutkas crutkas added this to the InVEST-2009 milestone Aug 28, 2020
@crutkas crutkas removed the Needs-Team-Response An issue author responded so the team needs to follow up label Aug 28, 2020
@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 28, 2020
@crutkas crutkas added the Priority-0 Bugs that we consider release-blocking/recall-class (P0) label Sep 10, 2020
@saahmedm saahmedm added the Priority-3 Bug that is low priority label Sep 11, 2020
@saahmedm saahmedm modified the milestones: InVEST-2009, InVEST-2010 Sep 14, 2020
@dsrivastavv
Copy link
Contributor

@crutkas I am able to repro this issue. While installing docker, uncheck Add shortcut to desktop on Configuration screen. This would install an lnk at location "C:\ProgramData\Microsoft\Windows\Start Menu", which is currently not in the list of watched folder. I will put a fix for this.

@dsrivastavv dsrivastavv self-assigned this Sep 28, 2020
@dsrivastavv dsrivastavv added the Status-In progress This issue or work-item is under development label Sep 28, 2020
@crutkas crutkas moved this from To do to In progress in 0.23 release Sep 29, 2020
@crutkas crutkas added this to To do in 0.25 release via automation Sep 30, 2020
@crutkas crutkas removed this from In progress in 0.23 release Sep 30, 2020
@crutkas crutkas moved this from To do to In progress in 0.25 release Sep 30, 2020
@saahmedm saahmedm removed the Priority-3 Bug that is low priority label Oct 1, 2020
@dsrivastavv dsrivastavv added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Needs-Repro We can't figure out how to make this happen. Please help find a simplified repro. Status-In progress This issue or work-item is under development labels Oct 2, 2020
@crutkas crutkas moved this from In progress to Done in 0.25 release Oct 8, 2020
@crutkas
Copy link
Member

crutkas commented Oct 29, 2020

@crutkas crutkas closed this as completed Oct 29, 2020
@Z1ni
Copy link
Author

Z1ni commented Oct 29, 2020

Confirmed to be working 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-PowerToys Run Improved app launch PT Run (Win+R) Window Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
No open projects
0.25 release
  
Done
Development

No branches or pull requests

7 participants