Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tools] Add DShow webcam report tool #10502

Merged
merged 8 commits into from
Mar 30, 2021

Conversation

yuyoyuppe
Copy link
Collaborator

@yuyoyuppe yuyoyuppe commented Mar 30, 2021

Summary of the Pull Request

What is this about:
This PR adds DShowWebcamReportTool, which will report all supported video format modes for all web cameras in your system. The info is printed to WebcamReport.txt.

What is include in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@github-actions
Copy link

Misspellings found, please review:

  • AMPROPERTY
  • AMPROPSETID
  • CDEF
  • cguid
  • devenum
  • DEVMON
  • dshow
  • IBase
  • ICreate
  • IKs
  • IMoniker
  • IPin
  • IProperty
  • majortype
  • MEDIASUBTYPE
  • MEDIATYPE
  • MJPG
  • PINDIR
  • Strmiids
  • VIDEOINFOHEADER
  • wistd
  • YUY
  • YUYV
To accept these changes, run the following commands from this repository on this branch
pushd $(git rev-parse --show-toplevel)
perl -e '
my @expect_files=qw('".github/actions/spell-check/expect.txt"');
@ARGV=@expect_files;
my @stale=qw('"BText GText INITGUID installpath RText Webcam "');
my $re=join "|", @stale;
my $suffix=".".time();
my $previous="";
sub maybe_unlink { unlink($_[0]) if $_[0]; }
while (<>) {
  if ($ARGV ne $old_argv) { maybe_unlink($previous); $previous="$ARGV$suffix"; rename($ARGV, $previous); open(ARGV_OUT, ">$ARGV"); select(ARGV_OUT); $old_argv = $ARGV; }
  next if /^(?:$re)(?:(?:\r|\n)*$| .*)/; print;
}; maybe_unlink($previous);'
perl -e '
my $new_expect_file=".github/actions/spell-check/expect.txt";
use File::Path qw(make_path);
make_path ".github/actions/spell-check";
open FILE, q{<}, $new_expect_file; chomp(my @words = <FILE>); close FILE;
my @add=qw('"AMPROPERTY AMPROPSETID CDEF cguid devenum DEVMON dshow IBase ICreate IKs IMoniker initguid IPin IProperty majortype MEDIASUBTYPE MEDIATYPE MJPG PINDIR Strmiids VIDEOINFOHEADER webcam wistd YUY YUYV "');
my %items; @items{@words} = @words x (1); @items{@add} = @add x (1);
@words = sort {lc($a) cmp lc($b)} keys %items;
open FILE, q{>}, $new_expect_file; for my $word (@words) { print FILE "$word\n" if $word =~ /\w/; };
close FILE;'
popd

yuyoyuppe and others added 3 commits March 30, 2021 17:33
Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
Copy link
Contributor

@enricogior enricogior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enricogior enricogior added the Product-Video Conference Mute Refers to the Video Conference muting tool label Mar 30, 2021
@yuyoyuppe yuyoyuppe merged commit ffda6a5 into microsoft:master Mar 30, 2021
@yuyoyuppe yuyoyuppe deleted the webcam_report_tool branch March 30, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Video Conference Mute Refers to the Video Conference muting tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants