Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new YAML release pipeline to replace the old CDPx one #15039

Merged
merged 84 commits into from
Dec 18, 2021

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Dec 16, 2021

Summary of the Pull Request

What is this about:
new loc system, new signing system, new build agent Oh My!

What is included in the PR:

How does someone test / validate:

Quality Checklist

  • Linked issue: #xxx
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

@microsoft microsoft deleted a comment from github-actions bot Dec 17, 2021
@microsoft microsoft deleted a comment from github-actions bot Dec 17, 2021
@crutkas
Copy link
Member Author

crutkas commented Dec 17, 2021

https://dev.azure.com/microsoft/Dart/_build/results?buildId=42914080&view=results should have updated result installer based off main with new DLL naming

@Jay-o-Way
Copy link
Collaborator

LOL looking at all the commits and seeing stuff like "What if...", "playing with slashes", "surprise", "trying my next oops", "sad panda", "i made a major oops" ...
It's hilarious!!! 🤣🤣🤣

@Jay-o-Way Jay-o-Way added the Area-Build Issues pertaining to the build system, CI, infrastructure, meta label Dec 17, 2021
@crutkas crutkas requested a review from DHowett December 17, 2021 23:02
@DHowett
Copy link
Member

DHowett commented Dec 17, 2021

Blocked behind #15054.

.pipelines/release.yml Outdated Show resolved Hide resolved
.pipelines/release.yml Outdated Show resolved Hide resolved
Fixing Dustin comments
@crutkas crutkas requested a review from DHowett December 17, 2021 23:23
@DHowett DHowett changed the title update pipeline to new signing build server Add a new YAML release pipeline to replace the old CDPx one Dec 17, 2021
@DHowett
Copy link
Member

DHowett commented Dec 17, 2021

There will be fallout, and the old CDPx pipeline may explode from it. We should monitor.

Touchdown is not fully localizing some of our stuff. I have a ticket with them. UNTIL IT IS RESOLVED, we cannot produce a reliable final build from this pipeline. However, it is worth merging.

Otherwise, this is nearly good to go.

@crutkas
Copy link
Member Author

crutkas commented Dec 17, 2021

Lemme kick off a CDPx test

@crutkas crutkas merged commit d5a2bf1 into main Dec 18, 2021
@crutkas crutkas deleted the dev/crutkas/updatePipeline branch December 18, 2021 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants