Merge PowerLauncher branch

[traies]

Summary of the Pull Request

Merge PowerLauncher branch. Alt+Space starts PowerLauncher.

References

#2332

PR Checklist

• Applies to Merge Launcher into build-feature #2332
• CLA signed. If not, go over here and sign the CLA

Known issues

• Clean Solution and Rebuild, otherwise the compiler complains about Wox.exe.
• Enabling PowerLauncher on the Settings page is not instantanous, it takes 5-10 seconds to actually start up.
• Some of the PowerLauncher settings are not implemented yet, they appear disabled in the settings page.

[alekhyareddy28]

Please let me know if I'm missing something.

[traies]

Please let me know if I'm missing something.

1. That shouldn't happen, I'll fix that.
2. In the GIF the Open PowerLauncher shortcut is unset, I think that might be why Alt+Space does nothing.
3. No, just once. Then rebuilding twice should work (Settings needs to be build twice, thats a known issue).
4. Maximum number of results overwrites the Microsoft Indexer Plugin settings.

ill leave it to Alekhya to verify

[alekhyareddy28]

1. That shouldn't happen, I'll fix that.
2. In the GIF the Open PowerLauncher shortcut is unset, I think that might be why Alt+Space does nothing.
3. No, just once. Then rebuilding twice should work (Settings needs to be build twice, thats a known issue).
4. Maximum number of results overwrites the Microsoft Indexer Plugin settings.

Regarding 2, thank you for the clarification. We might want to set it to Alt+Space by default so that the user does not have to set it before starting out.

I'll take a look at the settings files where this information is being stored and get back to you. Want to get a better understanding there as we now have two settings files and I want to ensure that one does not conflict with the other.

[alekhyareddy28]

Regarding the PR -

1. I do see PowerLauncher integrating well with settings. It sets the hotkey in Appdata\Local\Microsoft\PowerToys\Launcher\settings.json and saves it in a file which overrides the settings.json in PowerLauncher Appdata.
2. Win R override works as expected.
3. Looked at the code made in commit fa31fbb3433c67e7b0fd7c4eae5b2839472d89f6 and it LGTM.

Suggestions which @jyuwono can clarify further-

1. We might want Alt+Space to be set by default so that the user doesn't have to set it.
2. Right now the maximum number of results is setting the number of results from the indexer plugin. I'm not sure this is what we want. The maxResultsToShow equivalent of Wox, sets the number of rows that we can see in the dropdown.

Do we want to set the total number of results that the list has (from all plugins I'm assuming) or the maximum number of rows that we can see in the dropdown jessica?

[jyuwono]

Suggestions which @jyuwono can clarify further-

1. We might want Alt+Space to be set by default so that the user doesn't have to set it.
2. Right now the maximum number of results is setting the number of results from the indexer plugin. I'm not sure this is what we want. The maxResultsToShow equivalent of Wox, sets the number of rows that we can see in the dropdown.

Do we want to set the total number of results that the list has (from all plugins I'm assuming) or the maximum number of rows that we can see in the dropdown jessica?

@alekhyareddy28

1. Yes, let's set it by default.
2. It is the maximum number of rows that are visible in the dropdown, not number of results that the list has

[alekhyareddy28]

LGTM!