"Launch" versus "open" and "go to" #32351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jay-o-Way
commented
Apr 11, 2024
| @@ -36,7 +36,7 @@ protected override void OnNavigatedFrom(NavigationEventArgs e) | |||
|
|
|||
| private void Launch_EnvironmentVariables_Click(object sender, Microsoft.UI.Xaml.RoutedEventArgs e) | |||
| { | |||
| bool launchAdmin = SettingsRepository<EnvironmentVariablesSettings>.GetInstance(new SettingsUtils()).SettingsConfig.Properties.LaunchAdministrator; | |||
| bool launchAdmin = SettingsRepository<EnvironmentVariablesSettings>.GetInstance(new SettingsUtils()).SettingsConfig.Properties.OpenAsAdministrator; | |||
There was a problem hiding this comment.
Wait, is this a breaking change
There was a problem hiding this comment.
Might be, because it will change the JSON stored name and also the DSC.
Also included "Go to online documentation" and "Create Bug report file" to be explicit about their action
Also included "Go to online documentation" and "Create Bug report file" to be explicit about their action
|
This is too big of a single change. |
@crutkas Why. And what do you propose? |
Hi @Jay-o-Way , here's some ideas for splitting it:
Another split that's helpful here is for the user facing strings, do:
|
|
Thanks for opening the PR, by the way 😉 |
Jay-o-Way
force-pushed
the
launch-open-go
branch
from
2f14b7e
to
ffaea21
Compare
|
@jaimecbernardo now THAT'S a comment I can work with! Thank's! |
This was referenced Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Lots of changed words, using
PR Checklist
Validation Steps Performed
Build and go through various windows.