Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize all OnThreadExecutor fields and clarify intent further #701

Merged
merged 1 commit into from
Nov 12, 2019
Merged

initialize all OnThreadExecutor fields and clarify intent further #701

merged 1 commit into from
Nov 12, 2019

Conversation

yuyoyuppe
Copy link
Collaborator

Summary of the Pull Request

  • _active wasn't initialized, so sometimes OnThreadExecutor thread could exit instantly.
  • renamed _active to _shutdown_request to clarify its purpose

PR Checklist

Validation Steps Performed

Launched the app multiple times both in debug and release configurations

enricogior
enricogior approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@enricogior enricogior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested as well and the hang doesn't reproduce anymore.

@yuyoyuppe yuyoyuppe merged commit 4e771ec into microsoft:master Nov 12, 2019
@yuyoyuppe yuyoyuppe deleted the issue_699 branch November 27, 2019 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enricogior enricogior enricogior approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuyoyuppe @enricogior