Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathTutor Code #512

Merged
merged 4 commits into from
Feb 29, 2024
Merged

MathTutor Code #512

merged 4 commits into from
Feb 29, 2024

Conversation

ArpitaisAn0maly
Copy link
Contributor

Code for MathTutor Beat functionality.
Temporary UI code and placeholder for environment vaaribles is included in code which is to be replaced when permanent UI becomes available.

Copy link
Contributor

@georearl georearl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1. Tool to calculate pythagorean theorem
#2 .tool to calculate the area of a circle

These seem very specific to a scenario. Why is that? Concern is if the tutor is able to handle unexpected math problems? Would we need to ad in lots more tools?

@ArpitaisAn0maly
Copy link
Contributor Author

ArpitaisAn0maly commented Feb 27, 2024

#1. Tool to calculate pythagorean theorem #2 .tool to calculate the area of a circle

These seem very specific to a scenario. Why is that? Concern is if the tutor is able to handle unexpected math problems? Would we need to ad in lots more tools?

These two tools are added as an example for users to show this is how they can add custom tools for their specific tasks. Purpose of tool is to perform specific tasks. These tools comes into play when Math tools from Lanchchain is unable to perform calculation. Idea here is in beta version we show how to add custom tools and going forward users can add/update tools based on their specific requirement. We will only add more tools in future if and when a functionality is common ask by many users and default Math module is unable to solve it.

Copy link
Contributor

@dayland dayland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is an early stage PR for this feature, but don't forget to start adding Feature documentation for this code. Particularly, cover the use of Agents and Tools, custom Tools and how to plug them in, etc.

@georearl georearl merged commit 1ff167f into vNext-Dev Feb 29, 2024
6 checks passed
@georearl georearl deleted the aparmar/6479-Math-Tutor branch February 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants