Fix/weird travis test fail #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and pray that this will work on Travis, linux, pytest 4.6.1
Why..? It looks like the assert cannot handle an == on the same line
Codecov Report
@@ Coverage Diff @@
## master #1587 +/- ##
=======================================
Coverage 72.18% 72.18%
=======================================
Files 112 112
Lines 12293 12293
=======================================
Hits 8874 8874
Misses 3419 3419 |
astafan8
approved these changes
Jun 3, 2019
|
Just for completeness, I think it's this issue that we saw: pytest-dev/pytest#5372 So the problem would also go away in |
|
thanks for the completeness! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some combinations of
pytestversion4.6.1and [we don't quite know what] version?, tests that useassert all(...) is Trueorassert not all(...)fail.Since we can't really figure out which package versions to avoid, let's avoid using that syntax instead.
Changes proposed in this pull request:
@astafan8