Driver/ats9360 #400
Closed
Driver/ats9360 #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ATS9870-dev-branch
…into ATS9870-dev-branch
Generalise ATS.py and debugging. Changes to example notebook. Add specific ATS9360.py file for board settings. nb in this commit there is no use of the acquisition controller
…ith updated ATS driver
…rrectly and new eg notebook (needs cleaning up)
…TS get_sample_speed
… and no setpoints yet
… new records controller, put fit in acq helpers
…et_max_demod_freq()
…riable param so that setpoints will be updated when demod_freqs changed
…, bigger inheritance needed but will do that later
…t ATS9360 class, should be more general
…ssary and doing most of rec_samp controller and buf_rec controller
…reshape logic in others
|
Notes to self: Should probably revert e8190ec that seems to be unrelated and should if needed go in on a different branch |
This was referenced Feb 13, 2017
|
This should be probably closed ? |
|
Yes closed as replaced by #491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should replace #293
Changes proposed in this pull request:
make Alazar driver work for ATS9360 as well as ATS9870
add acquisition controllers for arraylike alazar parameter for use with ATS9360 (but easily adaptable to other alazar cards)
add example notebook
add aux.io functionality to alazar driver
I've written it such that the get_sample_rate function doesn't work for the ATS9360 and i'm not sure what the best way to implement this such that it works is (the issue is that the byte to value dict of the sampling rate should be different depending on the value of another parameter which sets how it works out the sample rate, not sure the 'nice' way to write this')
how should different acq controllers be organised? all in one big file seems messy but also the way I've done it seems overkill, maybe just have two files in the master branch: the existing one by @damazter and one which works for the ATS9360 and returns an array
currently the two acq controllers rec_samp and rec_buf don't work, they are designed to return a 2d dataset in one acquisition, I didnt try super hard to get them to work but also not sure why they don't, @alexcjohnson any ideas?
where should filters live considering that they are a quite general tool, also how do I deal with the whole import scipy thing...
@alexcjohnson @giulioungaretti @WilliamHPNielsen