driver/Alazar Ats9360 ADC - cleaned up #491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ATS9870-dev-branch
…into ATS9870-dev-branch
Generalise ATS.py and debugging. Changes to example notebook. Add specific ATS9360.py file for board settings. nb in this commit there is no use of the acquisition controller
…ith updated ATS driver
…rrectly and new eg notebook (needs cleaning up)
…TS get_sample_speed
|
@nataliejpg We should think about getting this into QCoDes soon |
|
@jenshnielsen Could we remove it returning raw first or at least make it optional? |
jenshnielsen
commented
May 29, 2017
| # endregion | ||
|
|
||
| # handle that external clock and internal clock uses | ||
| # two different ways of setting the sample rate. | ||
| # We use the matching one and make the order one |
There was a problem hiding this comment.
mark the other one
jenshnielsen
commented
May 29, 2017
|
|
||
| if self.acquisition._average_records: | ||
| self.records_per_buffer._save_val(value) | ||
| self.buffers_per_acquisition._save_val(1) |
There was a problem hiding this comment.
Needs to change this to build in some heuristic that gets a sensible number of buffers
jenshnielsen
commented
May 29, 2017
| magA = np.mean(magA, axis=-1) | ||
| phaseA = np.mean(phaseA, axis=-1) | ||
|
|
||
| unpacked = [] |
There was a problem hiding this comment.
only if raw is wanted
these will be implemented in one controller eventually
fix: allocated_buffers and set_base_setpoints
Dominik-Vogel
changed the title
|
Hi guys, what is the status of this driver? |
|
This is replaced by #816 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted some commits that did not belong on #400 and merged with master