Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Document magic and slack as legacy #4334

Merged
merged 1 commit into from
Jul 4, 2022
Merged

API: Document magic and slack as legacy #4334

merged 1 commit into from
Jul 4, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Jun 30, 2022 •
edited

Since they only work with the loop dataset.

@codecov
Copy link

codecov bot commented Jun 30, 2022 •
edited

Codecov Report

Merging #4334 (29b1aaf) into master (29b1aaf) will not change coverage.
The diff coverage is n/a.

❗ Current head 29b1aaf differs from pull request most recent head 5e5ac7b. Consider uploading reports for the commit 5e5ac7b to get more accurate results

@@           Coverage Diff           @@
##           master    #4334   +/-   ##
=======================================
  Coverage   68.37%   68.37%           
=======================================
  Files         267      267           
  Lines       30961    30961           
=======================================
  Hits        21170    21170           
  Misses       9791     9791

@jenshnielsen
Copy link
Collaborator Author

bors merge

bors bot added a commit that referenced this pull request Jul 4, 2022
@bors @jenshnielsen
Merge #4334 #4351
9ef0a67 
4334: API: Document magic and slack as legacy r=jenshnielsen a=jenshnielsen

Since they only work with the loop dataset. 

4351: API: update instrument drivers to use public api r=jenshnielsen a=jenshnielsen



Co-authored-by: Jens H. Nielsen <Jens.Nielsen@microsoft.com>
@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

This PR was included in a batch that was canceled, it will be automatically retried

@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

Build succeeded:

@bors bors bot merged commit b02efc6 into microsoft:master Jul 4, 2022
@jenshnielsen jenshnielsen deleted the api/magic branch July 4, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

@Dominik-Vogel Dominik-Vogel Dominik-Vogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jenshnielsen @astafan8 @Dominik-Vogel