Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: update instrument drivers to use public api #4351

Merged
merged 2 commits into from
Jul 4, 2022
Merged

API: update instrument drivers to use public api #4351

merged 2 commits into from
Jul 4, 2022

Conversation

jenshnielsen
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 4, 2022 •
edited

Codecov Report

Merging #4351 (baa1bc1) into master (42dfe86) will increase coverage by 0.92%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master    #4351      +/-   ##
==========================================
+ Coverage   67.42%   68.35%   +0.92%     
==========================================
  Files         267      267              
  Lines       30961    30961              
==========================================
+ Hits        20877    21163     +286     
+ Misses      10084     9798     -286

@jenshnielsen
Copy link
Collaborator Author

bors merge

bors bot added a commit that referenced this pull request Jul 4, 2022
@bors @jenshnielsen
Merge #4334 #4351
9ef0a67 
4334: API: Document magic and slack as legacy r=jenshnielsen a=jenshnielsen

Since they only work with the loop dataset. 

4351: API: update instrument drivers to use public api r=jenshnielsen a=jenshnielsen



Co-authored-by: Jens H. Nielsen <Jens.Nielsen@microsoft.com>
astafan8
astafan8 approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

qcodes/instrument_drivers/Keysight/KeysightAgilent_33XXX.py Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

Canceled.

@jenshnielsen @astafan8
Update qcodes/instrument_drivers/Keysight/KeysightAgilent_33XXX.py
baa1bc1 
Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
@jenshnielsen jenshnielsen force-pushed the api/instrument_drivers_update_imports branch from c8429ed to baa1bc1 Compare July 4, 2022 13:10
@jenshnielsen
Copy link
Collaborator Author

bors merge

1 similar comment
@jenshnielsen
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

Already running a review

@bors
Copy link
Contributor

bors bot commented Jul 4, 2022

Build succeeded:

@bors bors bot merged commit eb526d7 into microsoft:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astafan8 astafan8 astafan8 approved these changes

@Dominik-Vogel Dominik-Vogel Dominik-Vogel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jenshnielsen @astafan8 @Dominik-Vogel