Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional validators on parameter at runtime #5426

Merged
merged 21 commits into from Oct 11, 2023

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Oct 6, 2023

This allows the user to add additional validators to a parameter at runtime either permanently (until explicitly removed) or temporarily via a context manager.

TODO

  • Docstrings
  • Examples

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #5426 (e61314d) into master (039a1f8) will increase coverage by 0.01%.
The diff coverage is 98.33%.

@@            Coverage Diff             @@
##           master    #5426      +/-   ##
==========================================
+ Coverage   68.31%   68.33%   +0.01%     
==========================================
  Files         341      341              
  Lines       29945    29994      +49     
==========================================
+ Hits        20457    20495      +38     
- Misses       9488     9499      +11     

Copy link
Contributor

@astafan8 astafan8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

qcodes/tests/parameter/test_validators.py Outdated Show resolved Hide resolved
qcodes/tests/parameter/test_validators.py Show resolved Hide resolved
qcodes/tests/parameter/test_validators.py Show resolved Hide resolved
qcodes/tests/parameter/test_validators.py Show resolved Hide resolved
qcodes/tests/parameter/test_validators.py Show resolved Hide resolved
@jenshnielsen jenshnielsen marked this pull request as ready for review October 9, 2023 12:52
@astafan8
Copy link
Contributor

oh! a news fragment?

@jenshnielsen jenshnielsen added this pull request to the merge queue Oct 11, 2023
@jenshnielsen jenshnielsen removed this pull request from the merge queue due to a manual request Oct 11, 2023
@jenshnielsen jenshnielsen added this pull request to the merge queue Oct 11, 2023
Merged via the queue into microsoft:master with commit bf76977 Oct 11, 2023
13 checks passed
@jenshnielsen jenshnielsen deleted the multi_validator branch October 11, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants