Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow additional validators on parameter at runtime #5426

Merged
merged 21 commits into from
Oct 11, 2023
Merged

Allow additional validators on parameter at runtime #5426

merged 21 commits into from
Oct 11, 2023
+406 −36

Commits on Oct 11, 2023

  1. Change internal representation of validator(s) to a list

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    92a4383 View commit details
    Browse the repository at this point in the history

  2. add basic add and remove to validators

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    06d0896 View commit details
    Browse the repository at this point in the history

  3. add basic test of multiple validators

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ea5685a View commit details
    Browse the repository at this point in the history

  4. check that we can validate everything if all validators removed

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    cc43dba View commit details
    Browse the repository at this point in the history

  5. test adding a validator via constructor

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2386e15 View commit details
    Browse the repository at this point in the history

  6. remove does not take an argument

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e1e4e02 View commit details
    Browse the repository at this point in the history

  7. implement validator context manager

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ea48894 View commit details
    Browse the repository at this point in the history

  8. Add test for context manager

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e854bca View commit details
    Browse the repository at this point in the history

  9. add doc string test

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    a609faa View commit details
    Browse the repository at this point in the history

  10. Better doc joining logic

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e95d36c View commit details
    Browse the repository at this point in the history

  11. dynamically generate paramter docs

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9e68584 View commit details
    Browse the repository at this point in the history

  12. add validators to snapshot

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    4def11f View commit details
    Browse the repository at this point in the history

  13. fix import

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e526292 View commit details
    Browse the repository at this point in the history

  14. Apply suggestions from code review 

    Co-authored-by: Mikhail Astafev <astafan8@gmail.com>
    @jenshnielsen @astafan8
    jenshnielsen and astafan8 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e6bad0c View commit details
    Browse the repository at this point in the history

  15. test adding removing via vals property

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    14a49e3 View commit details
    Browse the repository at this point in the history

  16. add docstrings for validator properies and methods

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    87b0e24 View commit details
    Browse the repository at this point in the history

  17. Add example of how to use validators

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    391ab0d View commit details
    Browse the repository at this point in the history

  18. check that removing from empty is handled correctly

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    aa78311 View commit details
    Browse the repository at this point in the history

  19. slighly simpler tests

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    9c0ef8b View commit details
    Browse the repository at this point in the history

  20. slight rewrite

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    f52dd0c View commit details
    Browse the repository at this point in the history

  21. Add news for 5426

    @jenshnielsen
    jenshnielsen committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e61314d View commit details
    Browse the repository at this point in the history