Better treshold calculation for chunked output #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives a much more accurate estimate when we are dealing with many small arrays that are merged into one. For example: For 6 elements array the overhead of sys.getsizeof gives a size increase with a factor of 6 In [2]: import numpy as np In [3]: d = np.array([[1,2,3],[4,5,6]]) In [4]: import sys In [5]: sys.getsizeof(d) Out[5]: 152 In [6]: d.dtype.itemsize * d.size Out[6]: 24
jenshnielsen
requested review from
astafan8,
einsmein,
samantha-ho and
trevormorgan
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5523 +/- ##
==========================================
- Coverage 66.32% 66.32% -0.01%
==========================================
Files 354 354
Lines 30954 30953 -1
==========================================
- Hits 20531 20530 -1
Misses 10423 10423 |
astafan8
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using sys.getsizeof which has a huge overhead when the row size is small.
E.g. a dataset with many small rows.
Also add a test for exporting pure numeric datasets which was previously not covered.
And correct a warning from opentelemetry due to non str attributes on log messages