Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better treshold calculation for chunked output #5523

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Better treshold calculation for chunked output #5523

merged 3 commits into from
Nov 16, 2023

Commits on Nov 16, 2023

  1. basic test that purely numeric data is exported correctly

    @jenshnielsen
    jenshnielsen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    aa01715 View commit details
    Browse the repository at this point in the history

  2. opentelemetry only supports str as attribute not path

    @jenshnielsen
    jenshnielsen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    bbf9651 View commit details
    Browse the repository at this point in the history

  3. Better calculation of array size. 

    This gives a much more accurate estimate when we are dealing with
many small arrays that are merged into one.

For example:
For 6 elements array the overhead of sys.getsizeof
gives a size increase with a factor of 6

In [2]: import numpy as np
In [3]: d = np.array([[1,2,3],[4,5,6]])
In [4]: import sys
In [5]: sys.getsizeof(d)
Out[5]: 152
In [6]: d.dtype.itemsize * d.size
Out[6]: 24
    @jenshnielsen
    jenshnielsen committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    3123af7 View commit details
    Browse the repository at this point in the history