New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore deprecated parameter setters and getters #790
Restore deprecated parameter setters and getters #790
Conversation
I put in on my todo list |
This does not solve the issue with the The issue is the following: a parameter is added using the |
Ok can you merge #788 and I will try to fix that here too |
Done. |
This is how the official documentation does it and avoids a number of linter warnings
unbreaks some scripts and drivers that may be relying on this
bd07c47
to
101c3bb
Compare
the order is still scrambled but there is not much we can do about that
Ok I think that should have been taken care of now too |
As far as I can see, it solves the issue. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in. More can be added later.
Author: Jens Hedegaard Nielsen <jenshnielsen@gmail.com> Restore deprecated parameter setters and getters (#790)
On top of #788
Basically add set and get back for delay and step as deprecated functions to unbreak anything that depends on it along with allowing step to be zero as documented in the tutorial.
Also updates the tutorial to use non deprecated properties